Re: [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

2016-05-09 Thread Alexandr Scherbatiy
On 5/5/2016 2:24 PM, Sergey Bylokhov wrote: On 05.05.16 14:11, Alexandr Scherbatiy wrote: Note that the component GConfig is not necessary the config which is used in drawing, and can be different from the GConfig of Graphics passed to the paint() method. This is still necessary change for

Re: Review Request JDK-6421058: When calls JSpinner.setEditor() the font in a JSpinner become is a bold

2016-05-09 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/9/2016 8:52 AM, Prem Balakrishnan wrote: Hi Sergey, Thankyou for the Review. http://cr.openjdk.java.net/~pkbalakr/6421058/webrev.01/ Updated patch as per review comments. [mainFrame.dispose(), by mistake I missed to uncomment which was comment

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-09 Thread Alexandr Scherbatiy
The first approach implies that a user should change all PopupFactory.getPopup(owner, contents, x, y) calls to OverridenPopupFactory.getPopup(owner, contents, x, y, true) to get a heavy-weight popup in his code. The second one looks better to me. It may have sense to restrict it only to 2 p

Re: Review Request JDK-6421058: When calls JSpinner.setEditor() the font in a JSpinner become is a bold

2016-05-09 Thread Sergey Bylokhov
Thanks, Looks fine.

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

2016-05-09 Thread Phil Race
I suppose that is a start. We will likely want more tests later. One thing to fix before this is pushed : 45 }catch(Exception cnf) { missing spaces here. -phil. On 05/06/2016 12:22 AM, Yuri Nesterenko wrote: Hi Phil, yes, thank you. I've added a simpler black box test for both Lin

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-09 Thread Rajeev Chamyal
Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.app.00/ Update: Added test case. Regards, Rajeev Chamyal From: Rajeev Chamyal Sent: 06 May 2016 17:14 To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net Su