Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-05-13 Thread Jim Graham
Another reason to avoid new API is that we don't have to involve the CCC to get this "bug fix" in... ...jim On 5/13/16 3:50 PM, Jim Graham wrote: That looks very tight. The only issue I'd have is that it would be better if this could be done with non-public API for

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-05-13 Thread Jim Graham
That looks very tight. The only issue I'd have is that it would be better if this could be done with non-public API for now - the map() methods could live on one of the sun.awt.image classes or even in a Swing implementation utility class and still work just fine. When we have more time to

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

2016-05-13 Thread Phil Race
On 05/11/2016 06:58 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.12 From an API perspective this seems fine with the caveats that you have follow-on implementation work to do and that I am not familiar

Re: [9] Review request for 8046031: UI of Java Web Start app isn't updated when changing Windows theme

2016-05-13 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/05/16 20:42, Semyon Sadetsky wrote: On 4/28/2016 7:46 PM, Sergey Bylokhov wrote: On 28.04.16 19:30, Semyon Sadetsky wrote: ok, then just make the new field private and do not use the interned string as a key. Why do you think it should be

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-13 Thread Anton Litvinov
Hello Semyon, Sergey and Alexander, Thank you very much for review of this fix. The new version of the fix was created. Could you please review the second version of the fix. Webrev (the 2nd version): http://cr.openjdk.java.net/~alitvinov/8041694/jdk9/webrev.01 The second version of the

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-13 Thread Semyon Sadetsky
On 5/13/2016 7:54 PM, Alexander Potochkin wrote: Hello I just checked the code in JDK9 and found that it still syncs only with the EDT and completely ignores the toolkit thread. I cannot agree. Robot uses native SunToolkit.syncNativeQueue() to syncs it with the native event queue.

Re: [9] Review request for 8046031: UI of Java Web Start app isn't updated when changing Windows theme

2016-05-13 Thread Sergey Bylokhov
On 10.05.16 19:42, Semyon Sadetsky wrote: I made the flag key private. Please review http://cr.openjdk.java.net/~ssadetsky/8046031/webrev.01/ Looks fine. -- Best regards, Sergey.

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-13 Thread Alexey Ivanov
Hi Mikhail, Thanks! Looks great now! Regards, Alexey On 12.05.2016 18:54, Alexander Potochkin wrote: Hello Mikhail Looks great! Thanks alexp On 5/12/2016 5:53 PM, Alexey Ivanov wrote: 56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) { Check for exception was added: