Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-08-10 Thread Jim Graham
Ah, yes, only ToolkitImages can be "not yet loaded" in that manner. A quick look suggests that a MRCI should not be an instance of MRTI, but MRCI.map() does not force its argument to be an instance of MRCI, just MRI, so it would be possible for someone to pass an MRTI to MRCI.map() and then it w

[8] Review Request: 8161664: Memory leak in com.apple.laf.AquaProgressBarUI: removed progress bar still referenced

2016-08-10 Thread Robin Stevens
Hello, please review the backport of the fix for 8161664 to 8u-dev. Approval for the backport: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-August/005781.html Bug: https://bugs.openjdk.java.net/browse/JDK-8161664 JDK-9 Review thread: http://mail.openjdk.java.net/pipermail/swing-dev/ 2016

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

2016-08-10 Thread Alexandr Scherbatiy
Suppose there is a text area with two lines with the same text: abcdefghij abcdefghij The char 'c' on the fist line has offset 2 and some coordinates (x1, y1) where x1 can have a floating point values like 21.25. The char 'c' on the second line has offset 13 and coordinates (x2, y2) where x2 i

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-08-10 Thread Alexander Scherbatiy
On 09/08/16 03:49, Jim Graham wrote: Does MultiResolutionCachedImage.map() work if the Image hasn't been loaded yet (where getWidth/Height(Observer) can return -1)? Can it ever be called in a case like that? Could we rely on the fact that getWidth/Height(Observer) returns -1 only for Toolkit