Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-10-31 Thread Jim Graham
Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *cr.openjdk.java.net/~aniyogi/8138771/webrev.05/* Thank yo

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Pete Brunet
On 10/31/16 11:38 AM, Phil Race wrote: > +1. > > I am assuming you made sure AccessBridgeCalls.c is not being compiled > during the JDK build as discussed earlier ... I looked into this. The obj is needed to build accessbridgeinspector/walker. Searching the built directories AccessBridgeCalls.*

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Phil Race
+1. I am assuming you made sure AccessBridgeCalls.c is not being compiled during the JDK build as discussed earlier ... -phil. On 10/31/2016 07:36 AM, Pete Brunet wrote: On 10/28/16 8:14 PM, Mandy Chung wrote: On Oct 28, 2016, at 1:59 PM, Philip Race wrote: If it is not in the image then t

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Mandy Chung
> On Oct 31, 2016, at 7:36 AM, Pete Brunet wrote: > > > > On 10/28/16 8:14 PM, Mandy Chung wrote: >>> On Oct 28, 2016, at 1:59 PM, Philip Race wrote: >>> >>> If it is not in the image then there is no point in the file existing. >>> Maybe this could just be a comment at the top of the includ

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Pete Brunet
On 10/28/16 8:14 PM, Mandy Chung wrote: >> On Oct 28, 2016, at 1:59 PM, Philip Race wrote: >> >> If it is not in the image then there is no point in the file existing. >> Maybe this could just be a comment at the top of the include file. >> > This works for me. Updated: http://cr.openjdk.java.ne

Re: [9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

2016-10-31 Thread Sergey Bylokhov
+1 Thanks. On 31.10.16 8:10, Prasanta Sadhukhan wrote: Ok. Added javadoc tag. http://cr.openjdk.java.net/~psadhukhan/8048702/webrev.01/ Regards Prasanta On 10/29/2016 1:05 AM, Sergey Bylokhov wrote: It seems that most of our deprecated api have an annotation and a javadoc tag. I guess we shou