Re: Back port of fix JDK-7067885: FileChooser does not display soft link name if link is to nonexistent file/directory to OpenJDK-8

2016-11-03 Thread Semyon Sadetsky
Alok, JDK-7067885 fix caused regression and was reverted. Consider to backport JDK-8168899. --Semyon On 04.11.2016 07:52, Sharma, Alok Kumar (OSTL) wrote: Hi, JDK-7067885 fix is applicab

Back port of fix JDK-7067885: FileChooser does not display soft link name if link is to nonexistent file/directory to OpenJDK-8

2016-11-03 Thread Sharma, Alok Kumar (OSTL)
Hi, JDK-7067885 fix is applicable to OpenJDK-8, Code changes and testing for OpenJDK-8 are done. Mercurial diff for updated source change: --

Re: [9] Review request for 8139394: more detailed message for "Could not initialize shell library"

2016-11-03 Thread Sergey Bylokhov
- semyon.sadet...@oracle.com wrote: > On 02.11.2016 19:23, Sergey Bylokhov wrote: > > > On 02.11.16 9:43, Semyon Sadetsky wrote: > The path is not printed because there always several paths to > look for > the system module. > But I did not get how filesystem read permission is

Re: [9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

2016-11-03 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/31/2016 3:03 PM, Sergey Bylokhov wrote: +1 Thanks. On 31.10.16 8:10, Prasanta Sadhukhan wrote: Ok. Added javadoc tag. http://cr.openjdk.java.net/~psadhukhan/8048702/webrev.01/ Regards Prasanta On 10/29/2016 1:05 AM, Sergey Bylokhov wrote:

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-11-03 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/31/2016 9:31 PM, Jim Graham wrote: Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *cr.openjdk.java.net/~aniyogi/813877

Re: [9] Review request for 8153522: Update JLightweightFrame to allow non-integer (and X/Y) scales

2016-11-03 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/28/2016 9:59 AM, Semyon Sadetsky wrote: On 10/25/2016 8:17 PM, Alexandr Scherbatiy wrote: On 9/29/2016 10:55 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8153522 webrev: http: