On 12/06/2017 09:39 AM, Semyon Sadetsky wrote:
On 12/06/2017 08:33 AM, Phil Race wrote:
Hi,
I have some additional comments on this old review thread. Hopefully
we can close it out soon
although it will need a CSR whatever ..
Since the implementation of ShellFolderManager filters out
So you seem to be saying that the listeners installed by the UI
component itself
can process events directly on the EDT thread, but application code must
use invokeLater ?
This is particularly important for events which cause structural updates
to the model and the UI.
May I then suggest the
Hi,
I have some additional comments on this old review thread. Hopefully we
can close it out soon
although it will need a CSR whatever ..
Since the implementation of ShellFolderManager filters out inaccessible
files we
should document this somewhere.
I suggest either on the class or relevant
Looks fine.
On 06/12/2017 05:20, Muneer Kolarkunnu wrote:
Hi Sergey,
I updated the webrev to incorporate your comment.
New webrev: http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.01/
I kept jtreg timeout as 4 minute by considering all other operations of the
test case.
Regards,
Hi Sergey,
I updated the webrev to incorporate your comment.
New webrev: http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.01/
I kept jtreg timeout as 4 minute by considering all other operations of the
test case.
Regards,
Muneer
-Original Message-
From: Sergey Bylokhov
Hi All,
Please review the fix for bug:
Bug: JDK-8190281 https://bugs.openjdk.java.net/browse/JDK-8190281
JDK 10 Webrev: http://cr.openjdk.java.net/~kaddepalli/8190281/webrev00/
This bug was created while root causing JDK-8187936, and the following
refactoring points have been addressed:
Hi all,
as a long Swing user I would like to vote against the proposed
changes. The fact is that the #setSelectionInterval and
#addSelectionInterval methods of the JList class exist in this form
for a very long time and any change in the behaviour of this methods
may break existing applications.