Re: [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

2017-12-06 Thread Phil Race
On 12/06/2017 09:39 AM, Semyon Sadetsky wrote: On 12/06/2017 08:33 AM, Phil Race wrote: Hi, I have some additional comments on this old review thread. Hopefully we can close it out soon although it will need a CSR whatever .. Since the implementation of ShellFolderManager filters out

Re: [10][JDK-8187936] Automatically selecting a new JTree node in a model listener can cause unusual behavior.

2017-12-06 Thread Phil Race
So you seem to be saying that the listeners installed by the UI component itself can process events directly on the EDT thread, but application code must use invokeLater ? This is particularly important for events which cause structural updates to the model and the UI. May I then suggest the

Re: [10] Review request for 8182041: File Chooser Shortcut Panel folders under on JDK 9

2017-12-06 Thread Phil Race
Hi, I have some additional comments on this old review thread. Hopefully we can close it out soon although it will need a CSR whatever .. Since the implementation of ShellFolderManager filters out inaccessible files we should document this somewhere. I suggest either on the class or relevant

Re: [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

2017-12-06 Thread Sergey Bylokhov
Looks fine. On 06/12/2017 05:20, Muneer Kolarkunnu wrote: Hi Sergey, I updated the webrev to incorporate your comment. New webrev: http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.01/ I kept jtreg timeout as 4 minute by considering all other operations of the test case. Regards,

Re: [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

2017-12-06 Thread Muneer Kolarkunnu
Hi Sergey, I updated the webrev to incorporate your comment. New webrev: http://cr.openjdk.java.net/~akolarkunnu/8191803/webrev/webrev.01/ I kept jtreg timeout as 4 minute by considering all other operations of the test case. Regards, Muneer -Original Message- From: Sergey Bylokhov

[10][JDK-8190281] Code cleanup in src\java.desktop\share\classes\javax\swing\tree\VariableHeightLayoutCache.java

2017-12-06 Thread Krishna Addepalli
Hi All, Please review the fix for bug: Bug: JDK-8190281 https://bugs.openjdk.java.net/browse/JDK-8190281 JDK 10 Webrev: http://cr.openjdk.java.net/~kaddepalli/8190281/webrev00/ This bug was created while root causing JDK-8187936, and the following refactoring points have been addressed:

Re: [10] Review Request: JDK-7108280 : JList.getSelectedValuesList fails if JList.setSelectionInterval larger than list

2017-12-06 Thread Andrej Golovnin
Hi all, as a long Swing user I would like to vote against the proposed changes. The fact is that the #setSelectionInterval and #addSelectionInterval methods of the JList class exist in this form for a very long time and any change in the behaviour of this methods may break existing applications.