Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-07 Thread Prasanta Sadhukhan
Modified webrev to rename to InteropProviderImpl http://cr.openjdk.java.net/~psadhukhan/fxswing.10/ Regards Prasanta On 5/7/2018 8:35 PM, Kevin Rushforth wrote: That name seems good to me. -- Kevin On 5/7/2018 8:01 AM, Prasanta Sadhukhan wrote: Would InteropProviderImpl sound good?

Re: [11] RFR [TEST][JDK-8197948] Create test for SwingSet2 main window

2018-05-07 Thread Muneer Kolarkunnu
Gentle Reminder. Regards, Muneer From: Muneer Kolarkunnu Sent: Thursday, May 03, 2018 7:34 AM To: swing-dev@openjdk.java.net Subject: [11] RFR [TEST][JDK-8197948] Create test for SwingSet2 main window Hi All, Please review the following, a new client sanity test case: Task:

Re: [11] RFR [JDK-8202718] Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Maximize and Close buttons

2018-05-07 Thread Sergey Bylokhov
Then looks fine. On 07/05/2018 10:48, Alexandre (Shura) Iline wrote: These changes seem to be consistent with what’s in Jemmy code-tools repository and, therefore, correct. Shura On May 7, 2018, at 5:47 AM, Muneer Kolarkunnu >

Bug # 8194873

2018-05-07 Thread Peter Quiring
I found a bug in swing that was introduced in Java9. See bug # 8194873 The problem is the addition of checking for VM_RMENU http://hg.openjdk.java.net/jdk/jdk/file/ba545e52b932/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp#l2718 Please remove this check or find another way

Re: [11] RFR [JDK-8202718] Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Maximize and Close buttons

2018-05-07 Thread Alexandre (Shura) Iline
These changes seem to be consistent with what’s in Jemmy code-tools repository and, therefore, correct. Shura > On May 7, 2018, at 5:47 AM, Muneer Kolarkunnu > wrote: > > Hi All, > > Please review fix for a bug in jemmy: > Bug:

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-07 Thread mandy chung
On 5/7/18 2:26 AM, Prasanta Sadhukhan wrote: Modified webrev to use InteropProvider http://cr.openjdk.java.net/~psadhukhan/fxswing.9/ This version looks good.   InteropProviderImpl name is okay with me. Mandy

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-07 Thread Kevin Rushforth
That name seems good to me. -- Kevin On 5/7/2018 8:01 AM, Prasanta Sadhukhan wrote: Would InteropProviderImpl sound good? Regards Prasanta On 5/7/2018 8:27 PM, Alan Bateman wrote: On 07/05/2018 10:26, Prasanta Sadhukhan wrote: : Modified webrev to use InteropProvider

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-07 Thread Prasanta Sadhukhan
Would InteropProviderImpl sound good? Regards Prasanta On 5/7/2018 8:27 PM, Alan Bateman wrote: On 07/05/2018 10:26, Prasanta Sadhukhan wrote: : Modified webrev to use InteropProvider http://cr.openjdk.java.net/~psadhukhan/fxswing.9/ This looks okay although for consistent then InteropImpl

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-07 Thread Alan Bateman
On 07/05/2018 10:26, Prasanta Sadhukhan wrote: : Modified webrev to use InteropProvider http://cr.openjdk.java.net/~psadhukhan/fxswing.9/ This looks okay although for consistent then InteropImpl could be renamed too. -Alan

[11] RFR [JDK-8202718] Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Maximize and Close buttons

2018-05-07 Thread Muneer Kolarkunnu
Hi All, Please review fix for a bug in jemmy: Bug: https://bugs.openjdk.java.net/browse/JDK-8202718 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8202718/webrev.00/ This fix is a copy of fix made in the Jemmy code-tools repository.

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

2018-05-07 Thread Prasanta Sadhukhan
On 5/6/2018 1:15 PM, Alan Bateman wrote: On 05/05/2018 16:20, Prasanta Sadhukhan wrote: Updated webrev to modify java.desktop module-info.java (only difference between webrev7 and this) to remove the duplicate exports of sun.awt so we will have now exports sun.awt to