Re: [11] Review Request: 8202878 com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java fails

+1 -phil. On 5/10/18, 6:42 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202878 Fix: http://cr.openjdk.java.net/~serb/8202878/webrev.00 The test tries to check that the JMenuItem will be collected by GC if it was removed fro

[11] Review Request: 8202878 com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java fails

Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8202878 Fix: http://cr.openjdk.java.net/~serb/8202878/webrev.00 The test tries to check that the JMenuItem will be collected by GC if it was removed from the menu. The problem is that the code below does not

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

PS .. there should be some tests on the JDK side that don't use FX Or at least a reasoned explanation as to why this isn't possible. -phil. On 5/10/18, 5:49 PM, Philip Race wrote: I've looked over the Swing code. No time to actually try it out so I can only comment on what I see. I am not sur

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

I've looked over the Swing code. No time to actually try it out so I can only comment on what I see. I am not sure what I think about class docs like "This class wraps .." I know no javadoc is generated but this module is exported and probably should say something less specific. In general

JOB | Permanent Web Developer (New York)

Hello, I'm working with an employer that is looking to hire a permanent senior developer (for their New York office) to work on migrating their legacy Swing app to the web using Javascript, React and Redux. Consequently I had hoped that some members of this mailing list may like to discuss furthe

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

I confirm that this fixes the issue. The interface change to make the two static methods e instance methods is a good change in any case. I am not a Swing "R"eviewer, but the .13 webrev gets a +1 from me. -- Kevin On 5/10/2018 8:20 AM, Prasanta Sadhukhan wrote: Hi Kevin,All, Please find th

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

Hi Kevin,All, Please find the modified webrev fixing this #1 issue http://cr.openjdk.java.net/~psadhukhan/fxswing.13/ via change in jdk/swing/interop/DropTargetContextWrapper.java#setDropTargetContext and FXDnD.java#postDropTargetEvent For me, #2 works, #3 doesn't work even now due to JDK-814