Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

2018-08-20 Thread Sergey Bylokhov
Hi, Muneer. Is it possible to enhance the test so it will fail if the images are not loaded by the editor pane(it will pass if you apply the patch w/o images)? On 19/08/2018 22:05, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:*Muneer Kolarkunnu *Sent:* Tuesday, August 14,

Re: [12] RFR [TEST][JDK-8209494] Create a test for SwingSet3 InternalFrameDemo

2018-08-20 Thread Sergey Bylokhov
Looks fine. On 19/08/2018 22:05, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:*Muneer Kolarkunnu *Sent:* Tuesday, August 14, 2018 10:32 PM *To:* [email protected] *Subject:* [12] RFR [TEST][JDK-8209494] Create a test for SwingSet3 InternalFrameDemo Hi All, Ple

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

2018-08-20 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 8/20/2018 12:20 PM, Krishna Addepalli wrote: Hi Sergey, Thanks for providing the test code. Now I understand why the constructors were explicitly written. After some discussions here, I understood that the "Compiler generated default constructor has the same access as t