Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

2018-08-30 Thread Alexandre (Shura) Iline
Thank you - makes sense now. > On Aug 30, 2018, at 10:10 AM, Sergey Bylokhov > wrote: > > Hi, Alexandr. > I assume that one of the purpose of the test is to check that the html > (including images) are correctly loaded to the EditorPane and present it to > the user. > If there are some issues

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

2018-08-30 Thread Sergey Bylokhov
Hi, Alexandr. I assume that one of the purpose of the test is to check that the html (including images) are correctly loaded to the EditorPane and present it to the user. If there are some issues like - absent of the image files - errors in the file system - bugs in EditorPane, etc which pre

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

2018-08-30 Thread Alexandre (Shura) Iline
Sergey, > On Aug 20, 2018, at 4:11 PM, Sergey Bylokhov > wrote: > > Hi, Muneer. > Is it possible to enhance the test so it will fail if the images are not > loaded by the editor pane(it will pass if you apply the patch w/o images)? I am trying to understand the use case. The images would be

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

2018-08-30 Thread Krishna Addepalli
Hi Prasanta, Thanks for the review. Here is the link to CSR: https://bugs.openjdk.java.net/browse/JDK-8210210 Krishna From: Prasanta Sadhukhan Sent: Thursday, August 30, 2018 12:28 PM To: Krishna Addepalli ; [email protected] Subject: Re: [12]RFR:JDK-8182041- FIle Chooser Sh

Re: RFR(M) : 8210039 : move OSInfo to top level testlibrary

2018-08-30 Thread Chris Hegarty
> On 30 Aug 2018, at 08:51, Alan Bateman wrote: > > On 28/08/2018 17:50, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html >>> 698 lines changed: 114 ins; 240 del; 344 mod >> Hi all, >> >> could you please review this clean up of jdk testlibrary? >> th

Re: RFR(M) : 8210039 : move OSInfo to top level testlibrary

2018-08-30 Thread Alan Bateman
On 28/08/2018 17:50, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html 698 lines changed: 114 ins; 240 del; 344 mod Hi all, could you please review this clean up of jdk testlibrary? the patch updates the tests to use jdk.test.lib.Platform instead of j