The simple testing that I did -- one each of a Swing app + JFXPanel and
a JavaFX app + SwingNode -- worked for me on my local build after
restoring that file. Some additional testing (necessarily limited to GTK
2 until the FX backport for GTK 3 is done) might be needed.
-- Kevin
On 9/5/2018
HI, Pankaj.
Can you please recheck that FX<-->Swing interop still works? Probably
there are some other than GThreadHelper issues
On 05/09/2018 11:44, Pankaj Bansal wrote:
Hello Kevin,
Thanks for pointing it out. I will remove this fix for now. I hope its
ok, if I create new webrev when I get
Hello Kevin,
Thanks for pointing it out. I will remove this fix for now. I hope its ok, if I
create new webrev when I get some more comments here.
Regards,
Pankaj Bansal
From: Kevin Rushforth
Sent: Wednesday, September 5, 2018 10:29 PM
To: Pankaj Bansal; [email protected]; swi
The backport of the following fix, which removes sun.misc.GThreadHelper,
will break all FX interop applications, even if GTK2 is used:
https://bugs.openjdk.java.net/browse/JDK-8154546 : Retire
sun.misc.GThreadHelper
The FX GTK port still uses that class, so the class needs to be left in
unti
Hi Phil,
Posting your question: Is it valid to fail the test, if it returns no shortcut
files?
The test runs only on windows, and without security manager, it is expected to
return some well known shortcuts like "Desktop", "Network" etc, which is why
I'm failing if none of these are returned.
Hi Sergey,
This method is a public API, and hence it is only meant for clients using the
API. Internally, WindowsPlacesBar.java directly calls
ShellFolder.get("fileChooserShortcutPanelFolders").
Couple other classes Win32ShellFolderManager2.java and ShellFolderManager.java
also use it directly.
Hi All,
The testfix turned out to be simpler than I thought. I just had to query the
preferred size before making the frame visible, so that the image is rendered
on screen properly, and now Robot is able to pick the color.
Here is the modified webrev:
http://cr.openjdk.java.net/~kaddepalli
Hi Prasanta,
Looks good to me
Regards,
Pankaj
-Original Message-
From: Phil Race
Sent: Tuesday, September 4, 2018 11:12 PM
To: Prasanta Sadhukhan
Cc: [email protected]
Subject: Re: [12] JDK-8202013: JEditorPane shows large HTML
unordered list bullets
+1
-phil.
On 09/04/201
Hi All,
Please review the patch for 8u-dev backport for JDK-8145547. It adds
conditional support for gtk3.
The original fix does not apply cleanly as few changes were done in jdk9
before the gtk3 support was added, major once being HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-80258
