Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

2018-09-12 Thread Sergey Bylokhov
On 11/09/2018 22:03, Prasanta Sadhukhan wrote: Why SynthLookAndFeel.updateStyle() which is called in SynthButtonUI.updateStyle(AbstractButton b) did not update the context which is passed to it? Is it possible that SynthButtonUI.installDefaults() was not called before getBaseline()? SynthButt

Re: [8u-backport] JDK 8145547: [AWT/Swing] Conditional support for GTK 3 on Linux

2018-09-12 Thread Kevin Rushforth
Looks fine. Btw, you have a trailing whitespace in gtk2_interface.c that you need to fix before you push (jcheck will tell you about that). -- Kevin On 9/12/2018 5:29 AM, Pankaj Bansal wrote: Hi, I have found a small mistake in gtk_interface.c. I had used wrong name of gtk3 lib at line 56.

Re: [8u-backport] JDK 8145547: [AWT/Swing] Conditional support for GTK 3 on Linux

2018-09-12 Thread Pankaj Bansal
Hi, I have found a small mistake in gtk_interface.c. I had used wrong name of gtk3 lib at line 56. I have correct the same in webrev.02. It is just a typo and should not have any effect on functionality. All should work the same as 01 version. Webrev: http://cr.openjdk.java.net/~pbansal/gtk3