thanks .. I guess you are deferring review of the rest of it to someone
from swing.
In that Swing area I have a minor update to the fix :
http://cr.openjdk.java.net/~prr/8211031.1 [*]
since I just realised (meaning just thought to check :-)), that the
private method
classExists() is called
Looks fine.
On 21/09/2018 00:23, Muneer Kolarkunnu wrote:
Hi All,
Please review the following, a new client sanity test case:
Task: https://bugs.openjdk.java.net/browse/JDK-8210994
Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8210994/webrev.00/
Looks fine.
On 20/09/2018 01:04, Vikrant Agarwal wrote:
Hi All,
Please review this new test for SwingSet3 FileChooserDemo:
Task: https://bugs.openjdk.java.net/browse/JDK-8210910
Webrev: http://cr.openjdk.java.net/~vagarwal/8210910/webrev.0/
Hi Alexey, Thanks for your review and below is the new Webrev.
http://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.03/
Please see below for inline comments.
Thanks and regards,
Shashi
From: Alexey Ivanov
Sent: Friday, September 21, 2018 2:09 PM
To: Shashidhara Veerabhadraiah ;
Hi Shashi,
SystemIcon.java
What is the purpose of new SystemIcon class?
It's not used anywhere but the provided test. Is this class really
needed then?
Is it supposed to become the public API for accessing system icons?
Why can't FileSystemView be used for that purpose as it was proposed in
Removal of module-info.java.extra is good.
Mandy
On 9/21/18 1:13 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8211031
webrev: http://cr.openjdk.java.net/~prr/8211031/
Removing some obsolete code which is the reason for a qualified export
from java.base to java.desktop.
Bug: https://bugs.openjdk.java.net/browse/JDK-8211031
webrev: http://cr.openjdk.java.net/~prr/8211031/
Removing some obsolete code which is the reason for a qualified export
from java.base to java.desktop. I also cleaned up some commented out
debugging code.
See the bug evaluation for more
Hi All,
Please review the following, a new client sanity test case:
Task: https://bugs.openjdk.java.net/browse/JDK-8210994
Webrev Link: http://cr.openjdk.java.net/~akolarkunnu/8210994/webrev.00/
Summary: This is a new test to automate testing of SwingSet3 FrameDemo.
Please see the
