Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-01-14 Thread Sergey Bylokhov
Hi, Shashi. Should we trim all whitespaces from the "atNames"? Otherwise the "atNames", which contains only one whitespace, will trigger the same error. On 09/01/2019 00:20, Shashidhara Veerabhadraiah wrote: Hi Sergey, Thanks for pointing that out. Here is the new Webrev:

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

2019-01-14 Thread Sergey Bylokhov
Hi, Shashi. I am not sure I am understand the purpose of AccessibleBundleKey in your fix, you created a class which can be used as a key, but eventually you do not use it, except the calling of hashCode(). Note that the hashCode which you use as a key for a table may be the same for different

Re: [13] RFR JDK-8214111: There is no icon in all JOptionPane target image

2019-01-14 Thread Sergey Bylokhov
Hi, Pankaj. Based on the links below the next names were deprecated as well: "gtk-ok", "gtk-cancel", "gtk-dnd" etc. Should we change them as well? On 14/01/2019 04:26, Pankaj Bansal wrote: https://developer.gnome.org/gtk2/stable/gtk2-Stock-Items.html#GTK-STOCK-DIALOG-ERROR:CAPS

Re: [13] RFR JDK-8214471 : Enable different look and feel tests in SwingSet3 demo test ToolTipDemoTest

2019-01-14 Thread Sergey Bylokhov
Looks fine. On 14/01/2019 07:34, Muneer Kolarkunnu wrote: Hi All, Please review fix for the task: Task: https://bugs.openjdk.java.net/browse/JDK-8214471 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8214471/webrev/ Tested this on windows, linux and osx platforms in 1000 iterations, on

Re: [13] RFR JDK-8214471 : Enable different look and feel tests in SwingSet3 demo test ToolTipDemoTest

2019-01-14 Thread Alexandre (Shura) Iline
Looks good. Shura > On Jan 14, 2019, at 7:34 AM, Muneer Kolarkunnu > wrote: > > Hi All, > > Please review fix for the task: > Task: https://bugs.openjdk.java.net/browse/JDK-8214471 > > Webrev:

[13] RFR JDK-8214471 : Enable different look and feel tests in SwingSet3 demo test ToolTipDemoTest

2019-01-14 Thread Muneer Kolarkunnu
Hi All, Please review fix for the task: Task: https://bugs.openjdk.java.net/browse/JDK-8214471 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8214471/webrev/ Tested this on windows, linux and osx platforms in 1000 iterations, on SBR(Same Binary Run) setup, and passed without any

[13] RFR JDK-8214111: There is no icon in all JOptionPane target image

2019-01-14 Thread Pankaj Bansal
Hi All, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8214111 webrev: http://cr.openjdk.java.net/~pbansal/8214111/webrev.00/ Issue: The icons are not being displayed in JOptionPane for warning, error, info dialog etc. This issue is being observed in OEL