Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

2019-11-27 Thread Philip Race
Yes it needs a CSR. The updated wording explains when the "set*" methods are used/called but does not do the same for the get* methods. Why not for both ? -phil. On 11/24/19, 11:31 PM, Jayathirth Rao wrote: Its looks okay. Lets wait for Sergey’s inputs on the same. And I think it needs CSR

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-11-27 Thread Philip Race
1) I suppose this fix is for 14, not 13. 2) It is "OL", not "OEL" 3) Can we create a reliable automated test for this ? If not we should at least create a manual one. 4) A separate issue but we should consider adding a JSpinner demo to SwingSet2 -phil. On 11/27/19, 2:31 AM, Prasanta

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-11-27 Thread Prasanta Sadhukhan
It works for oel8 too. So the fix looks fine to me. Regards Prasanta On 27-Nov-19 3:54 PM, Prasanta Sadhukhan wrote: Hi Pankaj, I can see the issue resolved in ubuntu18.04 but not in OEL8. Also, SwingSet2 does not have JSpinner demo so we cannot put noreg-demo in JBS, so we probably need

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-11-27 Thread Prasanta Sadhukhan
Hi Pankaj, I can see the issue resolved in ubuntu18.04 but not in OEL8. Also, SwingSet2 does not have JSpinner demo so we cannot put noreg-demo in JBS, so we probably need a regression test, even manual, for this. Regards Prasanta On 25-Nov-19 4:13 PM, Pankaj Bansal wrote: Hi All,