Re: RFR: JDK-8234386: [macos] NPE was thrown at expanding Choice from maximized frame

Hi Sergey, Thank you for the review. Do I need another review? Additionally, I need a sponsor of the fix, since I'm not a committer. Thanks, Toshio Nakamura Sergey Bylokhov wrote on 2019/12/03 07:21:33: > From: Sergey Bylokhov > To: Toshio 5 Nakamura > Cc: swing-dev@openjdk.java.net >

Re: RFR(S): 8234913 Improve parsing of Length Units in javax/swing/text/html/CSS

Probably "java -verbose:class" might help? I guess after the fix this exception should not be loaded on successful parsing of "%". On 12/2/19 2:38 pm, Volodin, Vladislav wrote: Hello Sergey, indeed I wish I can create it. The main difficulty is that the exception (when it occurs) is handled

Re: RFR(S): 8234913 Improve parsing of Length Units in javax/swing/text/html/CSS

Hello Sergey, indeed I wish I can create it. The main difficulty is that the exception (when it occurs) is handled by try-catch and swallowed. So only if I turn on the debugger with “any exception” breakpoint, I will be able to find that the execution path was wrong. I am new here, and I will

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

On 12/2/19 3:15 am, Pankaj Bansal wrote: << Does it mean that this is the behavior of the gtk3 native spinner component? Yes, this behavior happens in native spinner. This change makes our Spinner much more similar to native gtk3 spinner "this behavior happens in native spinner" means after

Re: RFR(S): 8234913 Improve parsing of Length Units in javax/swing/text/html/CSS

Hi, Vladislav. Is it possible to provide an automated test for this change? On 11/28/19 2:08 am, Volodin, Vladislav wrote: Hello everyone, I'd like to contribute a little improvement to javax/swing/text/html/CSS. The issue is that "font-size: 100%" throws NumberFormatException for 100%,

Re: RFR: JDK-8234386: [macos] NPE was thrown at expanding Choice from maximized frame

Looks fine. On 11/25/19 2:54 am, Toshio 5 Nakamura wrote: Hi Sergey, > One small question about the test, is it necessary to check macOS only? Yes. Keyboard operations by robot are easy to reproduce the problem, but Keyboard don't work for Choice component in other platforms, such as

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

Hello Prasanta/Phil/Sergey, <<1) I suppose this fix is for 14, not 13. Yes, that was by mistake. I am not changes the subject line, as this would create separate mail thread. This will be pushed to 14 only. 2) It is "OL", not "OEL" Ok. 3) Can we create a reliable automated test for this ?

[14] RFR JDK-8227607: Broken external links in java.desktop

Hi All, Please review a doc-fix for removing some dead links from the specifications. These links were part of java.sun.com but has not been migrated to docs.oracle.com so it's better to remove them Bug: https://bugs.openjdk.java.net/browse/JDK-8227607 diff -r 7637e77c4c8a