Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

2019-12-17 Thread Sergey Bylokhov
Looks fine, please file a CSR. On 12/16/19 8:01 am, Tejpal Rebari wrote: Hi Sergey, I have updated the summary for setLargeModel. Please take a look : http://cr.openjdk.java.net/~trebari/swing/7020860/webrev2/ Regards Tejpal -- Best regards, Sergey.

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

2019-12-17 Thread Phil Race
66 UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel"); I think it would be better here to do something like what we have in javax/swing/JComboBox/7082443/bug7082443.java Eg : public static final String GTK_LAF_CLASS = "GTKLookAndFeel"; for

RFR : [15] : 8235900 : PopupMenu Opaque property is not reflecting the Parents property on MAC OS

2019-12-17 Thread Sureshkumar Mahaliswamy
Hi All, Kindly review the small patch. Added the annotation @requires(os.family!=mac) to ignore the test execution on MAC,since Aqua LaF forces all popups to be heavyweight. Marking this test not to be executed for MAC platform. JBS: