On Thu, 29 Oct 2020 05:09:24 GMT, Prasanta Sadhukhan
wrote:
> Please review a test fix for a test issue seen to be failing on mach5 macos
> systems due to timing issue.
> Modified the test to modify setAutoDelay() time, added delay() after frame is
> made visible and moved the frame to centre
Please review a test fix for a test issue seen to be failing on mach5 macos
systems due to timing issue.
Modified the test to modify setAutoDelay() time, added delay() after frame is
made visible and moved the frame to centre of screen.
Mach5 job has been run for several iterations in all
On Wed, 28 Oct 2020 11:50:20 GMT, Prasanta Sadhukhan
wrote:
> Please review a test fix for a test issue seen to be failing on mach5 macos
> systems due to timing issue.
> Modified the test to modify setAutoDelay() time, added delay() after frame is
> made visible, added waitForIdle() and also
On Wed, 28 Oct 2020 09:24:40 GMT, Prasanta Sadhukhan
wrote:
> Please review a test fix for an issue seen to be failing on mach5 systems due
> to timing issue, which is not reproducible locally.
> Modified the test to use setAutoDelay(), delay() after frame is made visible
> and also moved the
On Wed, 28 Oct 2020 17:34:07 GMT, Alexey Ivanov wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into JDK-8211999
>> - Update FullscreenWindowProps.java
>> -
On Wed, 28 Oct 2020 20:44:01 GMT, Alexey Ivanov wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into JDK-8211999
>> - Update FullscreenWindowProps.java
>> -
On Wed, 28 Oct 2020 16:24:20 GMT, Alexey Ivanov wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into JDK-8211999
>> - Update FullscreenWindowProps.java
>> -
> Hello.
> Please review the fix for jdk.
>
> Old review request:
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html
>
>
> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it
> should be fine for
> Windows 7, because it does not support different DPI
On Wed, 28 Oct 2020 11:50:20 GMT, Prasanta Sadhukhan
wrote:
> Please review a test fix for a test issue seen to be failing on mach5 macos
> systems due to timing issue.
> Modified the test to modify setAutoDelay() time, added delay() after frame is
> made visible, added waitForIdle() and also
> Hello.
> Please review the fix for jdk.
>
> Old review request:
> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html
>
>
> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it
> should be fine for
> Windows 7, because it does not support different DPI
On Wed, 28 Oct 2020 09:24:40 GMT, Prasanta Sadhukhan
wrote:
> Please review a test fix for an issue seen to be failing on mach5 systems due
> to timing issue, which is not reproducible locally.
> Modified the test to use setAutoDelay(), delay() after frame is made visible
> and also moved the
On Sun, 4 Oct 2020 06:22:45 GMT, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk.
>>
>> Old review request:
>> https://mail.openjdk.java.net/pipermail/awt-dev/2020-July/015991.html
>>
>>
>> (Note: the fix use API available since Windows 8.1: WM_DPICHANGED, but it
>> should
On Thu, 22 Oct 2020 20:46:15 GMT, Сергей Цыпанов
wrote:
> As discussed in https://github.com/openjdk/jdk/pull/510 there is never a
> reason to explicitly instantiate any instance of `Atomic*` class with its
> default value, i.e. `new AtomicInteger(0)` could be replaced with `new
>
On Wed, 28 Oct 2020 08:56:05 GMT, Сергей Цыпанов
wrote:
>> FYI it is better to use merge, instead of rebase+force push. Rebase breaks
>> history and all existed code comments.
>
> @mrserb thanks for pointing this out!
Thanks for updating with latest master changes Sergey! My tests were all
Please review a test fix for a test issue seen to be failing on mach5 macos
systems due to timing issue.
Modified the test to modify setAutoDelay() time, added delay() after frame is
made visible, added waitForIdle() and also finally dispose of the frame.
Mach5 job has been run for several
Please review a test fix for an issue seen to be failing on mach5 systems due
to timing issue, which is not reproducible locally.
Modified the test to use setAutoDelay(), delay() after frame is made visible
and also moved the frame to centre of screen. Removed the dependancy of Util
class and
On Wed, 28 Oct 2020 08:49:38 GMT, Sergey Bylokhov wrote:
>> Rebased onto master to have the fix introduced in
>> https://github.com/openjdk/jdk/pull/778
>
> FYI it is better to use merge, instead of rebase+force push. Rebase breaks
> history and all existed code comments.
@mrserb thanks for
On Wed, 28 Oct 2020 08:40:02 GMT, Сергей Цыпанов
wrote:
>> client changes are fine
>
> Rebased onto master to have the fix introduced in
> https://github.com/openjdk/jdk/pull/778
FYI it is better to use merge, instead of rebase+force push. Rebase breaks
history and all existed code comments.
On Wed, 28 Oct 2020 07:54:58 GMT, Sergey Bylokhov wrote:
> One more iteration of enabling tests. All of them sometimes fail in agentvm
> mode and works in othervm mode.
This pull request has now been integrated.
Changeset: 5e0a8cdf
Author:Sergey Bylokhov
URL:
> As discussed in https://github.com/openjdk/jdk/pull/510 there is never a
> reason to explicitly instantiate any instance of `Atomic*` class with its
> default value, i.e. `new AtomicInteger(0)` could be replaced with `new
> AtomicInteger()` which is faster:
> @State(Scope.Thread)
>
On Sat, 24 Oct 2020 23:12:09 GMT, Phil Race wrote:
>> Сергей Цыпанов has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains one additional
>> commit
On Wed, 28 Oct 2020 07:54:58 GMT, Sergey Bylokhov wrote:
> One more iteration of enabling tests. All of them sometimes fail in agentvm
> mode and works in othervm mode.
Marked as reviewed by psadhukhan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/895
One more iteration of enabling tests. All of them sometimes fail in agentvm
mode and works in othervm mode.
-
Commit messages:
- Update ProblemList.txt
Changes: https://git.openjdk.java.net/jdk/pull/895/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=895=00
Issue:
On Tue, 27 Oct 2020 14:23:32 GMT, Prasanta Sadhukhan
wrote:
> Please review test fix for issue seen to be failing in mach5 testing on macos.
> The tests issue are not reproducible locally so it seems to be timing issue
> on slower mach5 macos systems.
> Adjusted the timing issues in these
On Tue, 27 Oct 2020 05:07:01 GMT, Prasanta Sadhukhan
wrote:
> Please review a test fix for an issue seen to be failing in mach5 testing.
> Although initially the failure was reported on windows, it is problemlisted
> only for mac.
> It seems to be a timing issue resulting in failure in mach5
25 matches
Mail list logo
