> ListModel class javadoc refers to ListDataModel interface but there is no
> ListDataModel interface. Rectified the anomaly.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Copyright change
-
Changes:
- all: ht
ListModel class javadoc refers to ListDataModel interface but there is no
ListDataModel interface. Rectified the anomaly.
-
Commit messages:
- 8263410: ListModel javadoc refers to non-existent interface
Changes: https://git.openjdk.java.net/jdk/pull/2931/files
Webrev: https://webr
On Wed, 10 Mar 2021 18:09:37 GMT, Andrey Turbanov
wrote:
>
>
> There is one more occurrence of `ListDataModel` in JDK code -
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/ListModel.java#L34
> Perhaps it's worth to fix it too.
ok. will take a look.
-
On Wed, 10 Mar 2021 14:47:02 GMT, Pankaj Bansal wrote:
> If these changes are too intrusive, I can go with the second approach of
> getting and setting the current values of slider in
> performincrement/performdecrement functions in SliderAccessibility.m. I am
> not sure if this will be correc
On Wed, 10 Mar 2021 14:47:02 GMT, Pankaj Bansal wrote:
>>> If you need a new functionality and CSR I wonder how it currently works on
>>> Windows and macOS, or it does not work?
>>
>> Haven't tested this functionality on Windows, on macOS with current JDK it
>> does not work at all. After ente
On Mon, 8 Mar 2021 13:22:07 GMT, Alexander Zuev wrote:
> Fix updated after first round of review.
src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line 1044:
> 1042: new BufferedImage(iconSize, iconSize,
> BufferedImage.TYPE_INT_ARGB);
> 1043:
On Wed, 10 Mar 2021 00:58:36 GMT, Sergey Bylokhov wrote:
>> Marked as reviewed by kizune (Reviewer).
>
> I suggest always update the copyright.
There is one more occurrence of `ListDataModel` in JDK code -
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/Lis
On Wed, 10 Mar 2021 13:32:01 GMT, Alexander Zuev wrote:
> > If you need a new functionality and CSR I wonder how it currently works on
> > Windows and macOS, or it does not work?
>
> Haven't tested this functionality on Windows, on macOS with current JDK it
> does not work at all. After enteri
On Tue, 9 Mar 2021 21:27:39 GMT, Alexander Zuev wrote:
> Shouldn't you also increase the rolesMap initial capacity?
ok, I will do that in next commit.
-
PR: https://git.openjdk.java.net/jdk/pull/2874
On Wed, 10 Mar 2021 13:32:01 GMT, Alexander Zuev wrote:
> If you need a new functionality and CSR I wonder how it currently works on
> Windows and macOS, or it does not work?
-
PR: https://git.openjdk.java.net/jdk/pull/2874
On Wed, 10 Mar 2021 01:00:33 GMT, Sergey Bylokhov wrote:
> If you need a new functionality and CSR I wonder how it currently works on
> Windows and macOS, or it does not work?
Haven't tested this functionality on Windows, on macOS with current JDK it does
not work at all. After entering the JS
On Tue, 9 Mar 2021 08:09:04 GMT, Prasanta Sadhukhan
wrote:
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in re
On Wed, 10 Mar 2021 12:28:18 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>> but
On Wed, 10 Mar 2021 12:19:45 GMT, Alexey Ivanov wrote:
>> I think these are nouns and as per I know, we shouldn't place comma before
>> "and" when we are simply listing the items.
>
>> I think these are nouns and as per I know, we shouldn't place comma before
>> "and" when we are simply listing
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in reality all properties such as font, foreground, background, car
On Wed, 10 Mar 2021 12:13:43 GMT, Prasanta Sadhukhan
wrote:
> I think these are nouns and as per I know, we shouldn't place comma before
> "and" when we are simply listing the items.
This is called [Oxford
Comma](https://www.grammarly.com/blog/what-is-the-oxford-comma-and-why-do-people-care-s
On Wed, 10 Mar 2021 11:49:40 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> copyright change
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
> 306:
>
>> 3
On Wed, 10 Mar 2021 04:38:19 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>> but
On Wed, 10 Mar 2021 04:38:19 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>> but
On Wed, 10 Mar 2021 04:38:19 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>> but
20 matches
Mail list logo
