Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."

2021-08-11 Thread Prasanta Sadhukhan
On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan wrote: > The test fails in CI testing citing expected "rededited" but found > "redEDITED", which seems to point to fact that either there is a CAPS_LOCK > key switched on or some other test did not use SHIFT key corectly ie, > pressed but

Re: RFR: 5015261: JInternalFrame causes NPE [v2]

2021-08-11 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 02:20:51 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove test >> - Update javadoc clarification > >

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."

2021-08-11 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan wrote: > The test fails in CI testing citing expected "rededited" but found > "redEDITED", which seems to point to fact that either there is a CAPS_LOCK > key switched on or some other test did not use SHIFT key corectly ie, > pressed but

Re: RFR: 5015261: JInternalFrame causes NPE [v2]

2021-08-11 Thread Sergey Bylokhov
On Mon, 9 Aug 2021 04:21:08 GMT, Prasanta Sadhukhan wrote: >> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be >> called with null value. There are many places in JInternalFrame where >> getDesktopIcon() is accessed without null check which might cause NPE. >> Added

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-11 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-11 Thread Alexander Zuev
On Wed, 11 Aug 2021 15:16:22 GMT, Prasanta Sadhukhan wrote: > Does having 0,0 not create a problem in multiscreen environment? These coordinates are relative within the Graphics clip of the button so no, that does not cause any issue. Plus, if it would then button painting would be broken

Re: RFR: 5015261: JInternalFrame causes NPE [v2]

2021-08-11 Thread Prasanta Sadhukhan
On Mon, 9 Aug 2021 04:21:08 GMT, Prasanta Sadhukhan wrote: >> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be >> called with null value. There are many places in JInternalFrame where >> getDesktopIcon() is accessed without null check which might cause NPE. >> Added

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-11 Thread Prasanta Sadhukhan
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing

RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-11 Thread Alexander Zuev
Initial implementation and a test case. - Commit messages: - Test fixes - 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked Changes: https://git.openjdk.java.net/jdk/pull/5082/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5082=00

RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."

2021-08-11 Thread Prasanta Sadhukhan
The test fails in CI testing citing expected "rededited" but found "redEDITED", which seems to point to fact that either there is a CAPS_LOCK key switched on or some other test did not use SHIFT key corectly ie, pressed but not released. Considering many more tests would have failed if