Integrated: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-17 Thread Alexander Zuev
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v6]

2021-08-17 Thread Prasanta Sadhukhan
On Tue, 17 Aug 2021 06:09:51 GMT, Alexander Zuev wrote: >> Initial implementation and a test case. >> >> The problem is that Aqua LaF shows the focused component with the glow on >> the border, hence when the border is not painted the foxus is not displayed. >> The idea is to paint the

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v4]

2021-08-17 Thread Alexander Zuev
On Wed, 18 Aug 2021 04:59:36 GMT, Prasanta Sadhukhan wrote: > Have you checked if button does not have any text? Yes, i did. Neither my code nor native focus painter is affected by it. - PR: https://git.openjdk.java.net/jdk/pull/5082

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v4]

2021-08-17 Thread Prasanta Sadhukhan
On Tue, 17 Aug 2021 06:04:39 GMT, Alexander Zuev wrote: >> You can trace the usage of graphics.getColor() for example in >> AquaMenuItemUI/WindowsMenuUI/BevelBorder/etc to check that the old color >> property is usually saved and then restored. > >> You can trace the usage of

Re: RFR: 5015261: JInternalFrame causes NPE [v3]

2021-08-17 Thread Prasanta Sadhukhan
On Mon, 16 Aug 2021 21:10:10 GMT, Phil Race wrote: >>> We should either prevent null being set or catch all those nulls. >> >> I did that in 1st iteration of this >> PR..https://github.com/openjdk/jdk/pull/4989/files/2a2ab50ded3305f3a9e0f01e90417b484a0b2db4 >> >> >> @prrace Should I bring

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v6]

2021-08-17 Thread Sergey Bylokhov
On Tue, 17 Aug 2021 06:09:51 GMT, Alexander Zuev wrote: >> Initial implementation and a test case. >> >> The problem is that Aqua LaF shows the focused component with the glow on >> the border, hence when the border is not painted the foxus is not displayed. >> The idea is to paint the

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v3]

2021-08-17 Thread Prasanta Sadhukhan
On Tue, 17 Aug 2021 12:27:35 GMT, Alexey Ivanov wrote: > And using robot to release keys from EDT as part of the clean-up doesn't seem > right. I am just rectifying the order of the key release..It was pressed in order ALT SHIFT CONTROL and the release was ALT SHIFT CONTROL.. which I

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v3]

2021-08-17 Thread Alexey Ivanov
On Tue, 17 Aug 2021 05:37:47 GMT, Prasanta Sadhukhan wrote: >> The test fails in CI testing citing expected "rededited" but found >> "redEDITED", which seems to point to fact that either there is a CAPS_LOCK >> key switched on or some other test did not use SHIFT key corectly ie, >> pressed

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v2]

2021-08-17 Thread Alexey Ivanov
On Tue, 17 Aug 2021 05:37:16 GMT, Prasanta Sadhukhan wrote: > Since FIRST failure is > java/awt/SplashScreen/MultiResolutionSplash/MultiResolutionSplashTest.java > I tried to find tests that uses VK_SHIFT key which are … Can you reproduce the failure locally if the tests are run in the same

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v6]

2021-08-17 Thread Alexander Zuev
> Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing border on the focused component anyways. Alexander Zuev has

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked [v4]

2021-08-17 Thread Alexander Zuev
On Mon, 16 Aug 2021 23:46:18 GMT, Sergey Bylokhov wrote: > You can trace the usage of graphics.getColor() for example in > AquaMenuItemUI/WindowsMenuUI/BevelBorder/etc to check that the old color > property is usually saved and then restored. A few lines above paintFocus() is called there is