Re: RFR: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java [v2]

2021-08-26 Thread Alexey Ivanov
> Automated NimbusJTreeSelTextColor.java test which is added under > [JDK-8271315](https://bugs.openjdk.java.net/browse/JDK-8271315). > > It passes with the recent build of JDK 18. > It fails with JDK 18 build 7 where > [JDK-8266510](https://bugs.openjdk.java.net/browse/JDK-8266510) is not

Re: RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns letButton and rightButton as null with GTKLookAndFeel.

2021-08-26 Thread Sergey Bylokhov
On Thu, 26 Aug 2021 07:18:43 GMT, Pankaj Bansal wrote: > The function documentation for oneTouchExpandableChanged states that the > function does couple of things, but in reality it only does those things if > the Look and Feel supports the supportsOneTouchButtons. In case the Look and >

Integrated: 8272863: Replace usages of Collections.sort with List.sort call in public java modules

2021-08-26 Thread Andrey Turbanov
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. This pull request has now been integrated. Changeset: d732c309 Author:Andrey Turbanov Committer: Sergey Bylokhov URL:

Re: RFR: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java

2021-08-26 Thread Alexey Ivanov
On Thu, 26 Aug 2021 20:29:11 GMT, Sergey Bylokhov wrote: >> Automated NimbusJTreeSelTextColor.java test which is added under >> [JDK-8271315](https://bugs.openjdk.java.net/browse/JDK-8271315). >> >> It passes with the recent build of JDK 18. >> It fails with JDK 18 build 7 where >>

Re: RFR: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java

2021-08-26 Thread Sergey Bylokhov
On Thu, 26 Aug 2021 19:21:13 GMT, Alexey Ivanov wrote: > Automated NimbusJTreeSelTextColor.java test which is added under > [JDK-8271315](https://bugs.openjdk.java.net/browse/JDK-8271315). > > It passes with the recent build of JDK 18. > It fails with JDK 18 build 7 where >

RFR: 8273043: [TEST_BUG] Automate NimbusJTreeSelTextColor.java

2021-08-26 Thread Alexey Ivanov
Automated NimbusJTreeSelTextColor.java test which is added under [JDK-8271315](https://bugs.openjdk.java.net/browse/JDK-8271315). It passes with the recent build of JDK 18. It fails with JDK 18 build 7 where [JDK-8266510](https://bugs.openjdk.java.net/browse/JDK-8266510) is not fixed yet:

Re: RFR: 8271315: Redo: Nimbus JTree renderer properties persist across L changes [v4]

2021-08-26 Thread Alexey Ivanov
On Thu, 26 Aug 2021 19:09:38 GMT, Alexey Ivanov wrote: > I've submitted > [JDK-8273043](https://bugs.openjdk.java.net/browse/JDK-8273043) and made the > test automatic. I'll create PR after running the test in the CI. I've open the PR #5269. Testing is in progress. - PR:

Re: RFR: 8271315: Redo: Nimbus JTree renderer properties persist across L changes [v4]

2021-08-26 Thread Alexey Ivanov
On Thu, 26 Aug 2021 19:04:22 GMT, Sergey Bylokhov wrote: > I think it was pushed too fast, w/o looking into the new test. Yep, it seems so. I've submitted [JDK-8273043](https://bugs.openjdk.java.net/browse/JDK-8273043) and made the test automatic. I'll create PR after running the test in the

Re: RFR: 8271315: Redo: Nimbus JTree renderer properties persist across L changes [v4]

2021-08-26 Thread Sergey Bylokhov
On Wed, 25 Aug 2021 06:17:56 GMT, Prasanta Sadhukhan wrote: >> This is another attempt of fixing JDK-8249674 which created a regression >> JDK-8266510 for which it was backed out. >> This fix reinstates the UIResource properties for "Tree.leafIcon", >> "Tree.closedIcon", "Tree.openIcon",

Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-26 Thread Sergey Bylokhov
On Thu, 26 Aug 2021 17:39:36 GMT, Sergey Bylokhov wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >>

Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-26 Thread Sergei Ustimenko
On Thu, 26 Aug 2021 17:39:36 GMT, Sergey Bylokhov wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >>

Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-26 Thread Sergey Bylokhov
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote: >> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120. >> >> In many places standard charsets are looked up via their names, for example: >> absolutePath.getBytes("UTF-8"); >> >> This could be done more efficiently(up

Re: RFR: 8271315: Redo: Nimbus JTree renderer properties persist across L changes [v4]

2021-08-26 Thread Alexey Ivanov
On Wed, 25 Aug 2021 06:17:56 GMT, Prasanta Sadhukhan wrote: >> This is another attempt of fixing JDK-8249674 which created a regression >> JDK-8266510 for which it was backed out. >> This fix reinstates the UIResource properties for "Tree.leafIcon", >> "Tree.closedIcon", "Tree.openIcon",

Re: RFR: 8271315: Redo: Nimbus JTree renderer properties persist across L changes [v2]

2021-08-26 Thread Alexey Ivanov
On Wed, 25 Aug 2021 04:19:20 GMT, Prasanta Sadhukhan wrote: > It is reproducible but since is only color we tend to miss it since there is > no rule that it has to be of that color...As I told, I can create manual test > if that is what is needed.. A manual test could be better: this way

Integrated: 8271315: Redo: Nimbus JTree renderer properties persist across L changes

2021-08-26 Thread Prasanta Sadhukhan
On Thu, 19 Aug 2021 06:13:39 GMT, Prasanta Sadhukhan wrote: > This is another attempt of fixing JDK-8249674 which created a regression > JDK-8266510 for which it was backed out. > This fix reinstates the UIResource properties for "Tree.leafIcon", > "Tree.closedIcon", "Tree.openIcon",

RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns letButton and rightButton as null with GTKLookAndFeel.

2021-08-26 Thread Pankaj Bansal
The function documentation for oneTouchExpandableChanged states that the function does couple of things, but in reality it only does those things if the Look and Feel supports the supportsOneTouchButtons. In case the Look and Feel does not support supportsOneTouchButtons, this functions just