Re: RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules

2021-08-24 Thread Naoto Sato
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. java.time changes look good. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5229

Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-22 Thread Naoto Sato
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote: >> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120. >> >> In many places standard charsets are looked up via their names, for example: >> absolutePath.getBytes("UTF-8"); >> >> This could be done more efficiently(up

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Naoto Sato
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. >

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v3]

2021-01-19 Thread Naoto Sato
On Mon, 18 Jan 2021 05:52:57 GMT, Leo Jiang wrote: >> This is the changes for JDK 16 msg drop 10. > > Leo Jiang has updated the pull request incrementally with one additional > commit since the last revision: > > fix the missing copyright year for standard.properties Marked as reviewed by

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]

2021-01-15 Thread Naoto Sato
On Fri, 15 Jan 2021 01:59:07 GMT, Leo Jiang wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties >> line 518: >> >>> 516: doclet.footer_specified=\ >>> 517: The -footer option is no longer supported and will be ignored.\n\ >>> 518:

Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]

2021-01-14 Thread Naoto Sato
On Thu, 14 Jan 2021 14:27:25 GMT, Leo Jiang wrote: >> This is the changes for JDK 16 msg drop 10. > > Leo Jiang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull

Re: Swing Dev TextArea's/TextField's enableInputMethods is not working on linux

2011-05-26 Thread Naoto Sato
It simply sounds like a bug to me. The behavior should not be different. Naoto (5/26/11 12:25 AM), Sean Chou wrote: Hi all, I found TextArea's/TextField's enableInputMethods is not working on linux, even enableInputMethods(false) is invocated, the input method can still be enabled. The

Swing Dev hg: jdk7/swing/jdk: 7015500: Locale.toLanguageTag() uses und as lang subtag for private use only Locale

2011-02-08 Thread naoto . sato
Changeset: 842a0f8c89ea Author:naoto Date: 2011-02-08 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/842a0f8c89ea 7015500: Locale.toLanguageTag() uses und as lang subtag for private use only Locale Reviewed-by: srl ! src/share/classes/java/util/Locale.java !

Swing Dev hg: jdk7/swing/jdk: 7013282: No appropriate CCC request for listed JDK 7 changes in java.util.spi package (b121)

2011-02-03 Thread naoto . sato
Changeset: 0fae79ec7248 Author:naoto Date: 2011-02-03 09:59 -0800 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/0fae79ec7248 7013282: No appropriate CCC request for listed JDK 7 changes in java.util.spi package (b121) Reviewed-by: peytoia !

Swing Dev hg: jdk7/swing/jdk: 7002320: Locale.forLanguageTag()/toLanguageTag() not working properly with ja_JP_JP locale

2010-12-13 Thread naoto . sato
Changeset: 97e54a18d599 Author:naoto Date: 2010-12-13 13:16 -0800 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/97e54a18d599 7002320: Locale.forLanguageTag()/toLanguageTag() not working properly with ja_JP_JP locale Reviewed-by: dougfelt !

Swing Dev hg: jdk7/swing/jdk: 7000507: javadoc warnings in java.util.Locale; ...

2010-12-09 Thread naoto . sato
Changeset: ea504a083acd Author:naoto Date: 2010-12-09 15:22 -0800 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ea504a083acd 7000507: javadoc warnings in java.util.Locale 7004335: Javadoc for Locale.toLangaugeTag() is unclear 7005320: (lc) doc: missing in

Swing Dev hg: jdk7/swing/jdk: 2 new changesets

2010-12-09 Thread naoto . sato
Changeset: eb78026c92a9 Author:naoto Date: 2010-12-09 11:56 -0800 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/eb78026c92a9 6486695: [Col] Doc: CollationElementIterator example assumes Collator.getInstance return type Reviewed-by: okutsu !

Swing Dev hg: jdk7/swing/jdk: 6647615: Sample code in ListResourceBundle is not correct and causes a compile error.

2010-12-08 Thread naoto . sato
Changeset: 07f5669f1231 Author:naoto Date: 2010-12-08 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/07f5669f1231 6647615: Sample code in ListResourceBundle is not correct and causes a compile error. Reviewed-by: peytoia !

Swing Dev hg: jdk7/swing/jdk: 6989111: Incorrect default locale for New Zealand; ...

2010-11-02 Thread naoto . sato
Changeset: e4d839f8dfee Author:naoto Date: 2010-11-02 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e4d839f8dfee 6989111: Incorrect default locale for New Zealand 6990452: Provide system properties for the user specified script 6992312: Currency becomes XXX if do

Swing Dev hg: jdk7/swing/jdk: 6993339: Bug4168625Test.java fails

2010-10-22 Thread naoto . sato
Changeset: f52ad79e2826 Author:naoto Date: 2010-10-22 11:32 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f52ad79e2826 6993339: Bug4168625Test.java fails Reviewed-by: peytoia ! test/java/util/ResourceBundle/Bug4168625Test.java

Swing Dev hg: jdk7/swing/jdk: 6575419: Solaris : XSetICFoucs is not called with Java application at appropriate timing

2010-10-14 Thread naoto . sato
Changeset: cdbb6e073c60 Author:naoto Date: 2010-10-14 11:37 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/cdbb6e073c60 6575419: Solaris : XSetICFoucs is not called with Java application at appropriate timing Reviewed-by: okutsu !

Swing Dev hg: jdk7/swing/jdk: 6989440: tomcat test from dacapo benchmark fails with ConcurrentModificationException

2010-10-12 Thread naoto . sato
Changeset: b2cfe62ef802 Author:naoto Date: 2010-10-12 17:09 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/b2cfe62ef802 6989440: tomcat test from dacapo benchmark fails with ConcurrentModificationException Reviewed-by: okutsu Contributed-by: y.uma...@gmail.com !

Swing Dev hg: jdk7/swing/jdk: 6915621: (rb) ResourceBundle.getBundle() deadlock when called inside a synchronized thread

2010-09-28 Thread naoto . sato
Changeset: 75a0f7b47024 Author:naoto Date: 2010-09-28 10:57 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/75a0f7b47024 6915621: (rb) ResourceBundle.getBundle() deadlock when called inside a synchronized thread Reviewed-by: okutsu !

Swing Dev hg: jdk7/swing/jdk: 6986612: pit jdk7 b112: java.util.Locale getDisplayVariant() sqe test getDisplayVariantTests.java fails

2010-09-23 Thread naoto . sato
Changeset: 39351e11b8f9 Author:naoto Date: 2010-09-23 20:05 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/39351e11b8f9 6986612: pit jdk7 b112: java.util.Locale getDisplayVariant() sqe test getDisplayVariantTests.java fails Reviewed-by: dougfelt Contributed-by: Yoshito

Swing Dev hg: jdk7/swing/jdk: 2 new changesets

2010-09-02 Thread naoto . sato
Changeset: b83701dcae1e Author:naoto Date: 2010-09-02 11:09 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/b83701dcae1e 6981759: copyright header fix for test/java/util/Locale/LocaleCategory.java Reviewed-by: okutsu ! test/java/util/Locale/LocaleCategory.java Changeset:

Swing Dev hg: jdk7/swing/jdk: 6981466: Adding missing test LocaleCategory.java

2010-09-01 Thread naoto . sato
Changeset: 3b64274e3cda Author:naoto Date: 2010-08-31 23:56 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/3b64274e3cda 6981466: Adding missing test LocaleCategory.java Reviewed-by: okutsu + test/java/util/Locale/LocaleCategory.java

Swing Dev hg: jdk7/swing/jdk: 4700857: RFE: separating user locale and user interface locale

2010-08-31 Thread naoto . sato
Changeset: 48070a2633a1 Author:naoto Date: 2010-08-31 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/48070a2633a1 4700857: RFE: separating user locale and user interface locale Reviewed-by: okutsu ! src/share/classes/java/text/DateFormat.java !

Swing Dev hg: jdk7/swing/jdk: 6943941: Rebranding issues with some tests in jdk/test/java/util

2010-04-19 Thread naoto . sato
Changeset: 584dcb7ecaf9 Author:naoto Date: 2010-04-19 14:48 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/584dcb7ecaf9 6943941: Rebranding issues with some tests in jdk/test/java/util Reviewed-by: ohair ! test/java/util/Locale/Bug4175998Test.java !

Swing Dev hg: jdk7/swing/jdk: 2 new changesets

2009-07-23 Thread naoto . sato
Changeset: 5054103dc032 Author:naoto Date: 2009-06-30 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5054103dc032 6852429: IME should call ImmIsUIMessage() or DefWindowProc() when it receives WM_IME_SETCONTEX Reviewed-by: peytoia !