Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2017-01-12 Thread alexander popov
Yep, its reasonable! Will fix that and update diff. On 1/11/2017 1:39 PM, Avik Niyogi wrote: Hi Alexander, The following is my input for this webrev: In case the LAF is Aqua, the check for combobox alignment is skipped. Instead, if default LAF is Aqua, the LAF should be changed to cross

Fwd: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2016-12-26 Thread Alexander Popov
See new diffs here pls - http://cr.openjdk.java.net/~avstepan/8165207/webrev.02/ Sergey, failure could be reproduced on any OS X - just comment the following lines in my fix:   if (!UIManager.getLookAndFeel() .getName().toLowerCase().contains("os x"))

[9] Review request for 8160441: [PIT][TEST_BUG][macosx] javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java

2016-12-07 Thread Alexander Popov
Hello, review my changes please. Webrev: http://cr.openjdk.java.net/~yan/8160441/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8160441 This is a test bug. On Aqua LaF JScrollPane has index 1. On Metal LaF it has index 0 inside JPopupPane. So, I've decided to generalize finding