+1
- alexandr.scherba...@oracle.com wrote:
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 4/13/2017 6:57 PM, Mikhail Cherkasov wrote:
> >
> >
> > On 4/13/2017 6:31 PM, Phil Race wrote:
> >>31 import javax.swing.*;
> > Fixed:
> >
> http://cr.openjdk.java.net/~mcherkas/807624
The fix looks good to me.
Thanks,
Alexandr.
On 4/13/2017 6:57 PM, Mikhail Cherkasov wrote:
On 4/13/2017 6:31 PM, Phil Race wrote:
31 import javax.swing.*;
Fixed:
http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev.02/test/javax/accessibility/JList/AccessibleJListChildNPETest.java.html
On 4/13/2017 6:31 PM, Phil Race wrote:
31 import javax.swing.*;
Fixed:
http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev.02/test/javax/accessibility/JList/AccessibleJListChildNPETest.java.html
Minor nit, a wildcard import in the test :-
31 import javax.swing.*;
-phil
On 04/13/2017 06:16 AM, Mikhail Cherkasov wrote:
Hi Sergey,
Right, a test case can be written without use of JAWS or other screen
readers.
Please find a new webrev with the test there:
http://cr.openjdk.java.net/
Hi Sergey,
Right, a test case can be written without use of JAWS or other screen
readers.
Please find a new webrev with the test there:
http://cr.openjdk.java.net/~mcherkas/8076249/9/webrev.01/
Thanks,
Mikhail.
On 4/12/2017 9:19 PM, Sergey Bylokhov wrote:
Hi, Mikhail.
Is it possible to write
Hi, Mikhail.
Is it possible to write a test for this issue? I guess it is possible to force
NPE even without AccessBridge.
> Hello,
>
> Could you please review the fix for jdk9?
>
> AccessBridge works in separate thread,so if we modify JList model,
> AccessBridge can request information about r
Looks good to me.
-phil.
On 4/12/17, 10:04 AM, Mikhail Cherkasov wrote:
Hello,
Could you please review the fix for jdk9?
AccessBridge works in separate thread,so if we modify JList model,
AccessBridge can request information about removed AccessibleJListChild or
element
that changed position
Hello,
Could you please review the fix for jdk9?
AccessBridge works in separate thread,so if we modify JList model,
AccessBridge can request information about removed AccessibleJListChild or
element
that changed position, so this can lead to NPE.
Almost all methods of AccessibleJListChild has c
