This one seems like it got lost in my inbox.
I am OK with the fix but the opened test needs the GPL.
-phil.
On 04/07/2016 03:20 AM, Semyon Sadetsky wrote:
Hi Phil,
I have found one failed test. My fix adds extra element in the
HTMLDocument after insert operation.
Looks like the
Hi Phil,
I have found one failed test. My fix adds extra element in the
HTMLDocument after insert operation.
Looks like the HTMLDocument ignores the implied character in the
GapContent while the PlainDocument assume that it exists.
Both classes use the same GapContent code.
So, the fix need
There is actually a test for the previous bug - called bug4496801.java,
but it is in closed.
I suggest it be opened as part of this fix.
Also run any (all) related Swing regression tests that might cover this
area.
I am a little nervous that since the original fix was 13 years ago that some
Should the test also cover the html based string(and cover the changes
in HTMLDocument)?
On 16.03.16 21:06, Alexander Scherbatiy wrote:
The fix looks good to me.
Just a small comment: if it is a new test it probably should not contain
1998 year in the copyright.
Thanks,
Alexandr.
On
The fix looks good to me.
Just a small comment: if it is a new test it probably should not contain
1998 year in the copyright.
Thanks,
Alexandr.
On 14/03/16 20:48, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8151015
webrev:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8151015
webrev: http://cr.openjdk.java.net/~ssadetsky/8151015/webrev.00/
It is regression of 4496801. The fix for 4496801 was wrong and the
correct fix should be taking into account the implied character at the
