On Wed, 10 Mar 2021 12:28:18 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>>
On Wed, 10 Mar 2021 12:19:45 GMT, Alexey Ivanov wrote:
>> I think these are nouns and as per I know, we shouldn't place comma before
>> "and" when we are simply listing the items.
>
>> I think these are nouns and as per I know, we shouldn't place comma before
>> "and" when we are simply
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in reality all properties such as font, foreground, background,
On Wed, 10 Mar 2021 12:13:43 GMT, Prasanta Sadhukhan
wrote:
> I think these are nouns and as per I know, we shouldn't place comma before
> "and" when we are simply listing the items.
This is called [Oxford
On Wed, 10 Mar 2021 11:49:40 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> copyright change
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
> 306:
>
>>
On Wed, 10 Mar 2021 04:38:19 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>>
On Wed, 10 Mar 2021 04:38:19 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>>
On Tue, 9 Mar 2021 21:17:13 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
>> 306:
>>
>>> 304: * Initializes component properties, such as font, foreground,
>>> 305: * background, caret color, selection color, selected text
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in reality all properties such as font, foreground, background,
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in reality all properties such as font, foreground, background,
On Tue, 9 Mar 2021 21:31:03 GMT, Alexander Zuev wrote:
> I'm not an expert in English but i think comma after set is not needed.
You're right, comma is not needed in this case. I updated my comment and
removed the comma.
-
PR: https://git.openjdk.java.net/jdk/pull/2888
On Tue, 9 Mar 2021 21:12:08 GMT, Alexey Ivanov wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>> but in
On Tue, 9 Mar 2021 13:34:20 GMT, Alexander Zvegintsev
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>>
On Tue, 9 Mar 2021 08:09:04 GMT, Prasanta Sadhukhan
wrote:
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in
On Tue, 9 Mar 2021 08:09:04 GMT, Prasanta Sadhukhan
wrote:
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in
BasicTextUI: installDefaults javadoc specifies only font, foreground and
background properties are set if their current value is either null or a
UIResource
and other properties are set if the current value is null
but in reality all properties such as font, foreground, background, caret
16 matches
Mail list logo
