Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Ok. +1 -phil. On 8/10/20, 8:34 AM, Tejpal Rebari wrote: Gentle Reminder. On 04-Aug-2020, at 11:46 AM, Tejpal Rebari > wrote: Hi Phil, I have updated the path of the test. Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Gentle Reminder. > On 04-Aug-2020, at 11:46 AM, Tejpal Rebari wrote: > > Hi Phil, > I have updated the path of the test. > Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/ > > > Thanks > Tejpal > >> On

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Hi Phil, I have updated the path of the test. Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/ Thanks Tejpal > On 01-Aug-2020, at 9:41 PM, Philip Race wrote: > > We've been trying to get away from using

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

We've been trying to get away from using bug ids in path names or the names of the tests themselves. -phil On 7/29/20, 4:53 AM, Prasanta Sadhukhan wrote: On 29-Jul-20 1:25 PM, Tejpal Rebari wrote: Hi Prasanta, On 27-Jul-2020, at 2:21 PM, Prasanta Sadhukhan

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

On 29-Jul-20 1:25 PM, Tejpal Rebari wrote: Hi Prasanta, On 27-Jul-2020, at 2:21 PM, Prasanta Sadhukhan > wrote: Fix looks ok to me. But I think the test is more appropriate if it is placed in javax/swing/plaf/nimbus directory. Also, the test can be

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Hi Prasanta, > On 27-Jul-2020, at 2:21 PM, Prasanta Sadhukhan > wrote: > > Fix looks ok to me. But I think the test is more appropriate if it is placed > in javax/swing/plaf/nimbus directory. Also, the test can be enhanced a bit to > not fail at the first attempt as we are testing 8

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Fix looks ok to me. But I think the test is more appropriate if it is placed in javax/swing/plaf/nimbus directory. Also, the test can be enhanced a bit to not fail at the first attempt as we are testing 8 different properties, so I think it will be good if you will store the results in a

RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249674 Webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev00/ This