Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

2021-03-24 Thread Sergey Bylokhov
On Tue, 23 Mar 2021 14:55:58 GMT, Alexander Zvegintsev wrote: >> Looks like the original idea was to set `fallbacktext` on strings containing >> only spaces. >> >> I decided to remove the `trim()` call to keep the same behavior and to >> allows to set such meaningless space only titles/toolti

Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

2021-03-24 Thread Prasanta Sadhukhan
On Tue, 23 Mar 2021 14:55:58 GMT, Alexander Zvegintsev wrote: >> Looks like the original idea was to set `fallbacktext` on strings containing >> only spaces. >> >> I decided to remove the `trim()` call to keep the same behavior and to >> allows to set such meaningless space only titles/toolti

Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

2021-03-24 Thread Alexander Zvegintsev
On Tue, 23 Mar 2021 22:13:21 GMT, Sergey Bylokhov wrote: >> Yes, I think it would be better to allow to set empty text to conform with >> other LaF behavior. >> >> Also `JFileChooser.getApproveButtonText()` and >> `JFileChooser.getApproveButtonToolTipText()` will now return correct values >>

Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

2021-03-23 Thread Tejpal Rebari
On Tue, 23 Mar 2021 14:55:58 GMT, Alexander Zvegintsev wrote: >> Looks like the original idea was to set `fallbacktext` on strings containing >> only spaces. >> >> I decided to remove the `trim()` call to keep the same behavior and to >> allows to set such meaningless space only titles/toolti

Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

2021-03-23 Thread Sergey Bylokhov
On Tue, 23 Mar 2021 15:33:43 GMT, Alexander Zvegintsev wrote: >> src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java line >> 2059: >> >>> 2057: final String tooltipText = >>> fc.getApproveButtonToolTipText(); >>> 2058: if (tooltipText != null) { >>> 20

Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

2021-03-23 Thread Alexander Zvegintsev
On Tue, 23 Mar 2021 05:00:45 GMT, Prasanta Sadhukhan wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> allow empty text > > src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java line > 2059:

Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

2021-03-23 Thread Alexander Zvegintsev
> Looks like the original idea was to set `fallbacktext` on strings containing > only spaces. > > I decided to remove the `trim()` call to keep the same behavior and to allows > to set such meaningless space only titles/tooltips(same as on other > platforms, maybe someone want empty label for s