On Tue, 17 Aug 2021 06:09:51 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the
On Wed, 18 Aug 2021 04:59:36 GMT, Prasanta Sadhukhan
wrote:
> Have you checked if button does not have any text?
Yes, i did. Neither my code nor native focus painter is affected by it.
-
PR: https://git.openjdk.java.net/jdk/pull/5082
On Tue, 17 Aug 2021 06:04:39 GMT, Alexander Zuev wrote:
>> You can trace the usage of graphics.getColor() for example in
>> AquaMenuItemUI/WindowsMenuUI/BevelBorder/etc to check that the old color
>> property is usually saved and then restored.
>
>> You can trace the usage of
On Tue, 17 Aug 2021 06:09:51 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing border on the focused component anyways.
Alexander Zuev has
On Mon, 16 Aug 2021 23:46:18 GMT, Sergey Bylokhov wrote:
> You can trace the usage of graphics.getColor() for example in
> AquaMenuItemUI/WindowsMenuUI/BevelBorder/etc to check that the old color
> property is usually saved and then restored.
A few lines above paintFocus() is called there is
On Mon, 16 Aug 2021 23:39:05 GMT, Alexander Zuev wrote:
>> What about the color property?
>
>> What about the color property?
>
> That would be unnecessary, whoever does painting does not just assumes that
> the color is set to his preferred choice, everywhere in the code color is set
> up
On Mon, 16 Aug 2021 20:53:56 GMT, Sergey Bylokhov wrote:
> What about the color property?
That would be unnecessary, whoever does painting does not just assumes that the
color is set to his preferred choice, everywhere in the code color is set up
before doing any painting and i do not see
On Mon, 16 Aug 2021 19:45:11 GMT, Alexander Zuev wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 340:
>>
>>> 338: Color ringColor = UIManager.getColor("Focus.color");
>>> 339: g.setColor(ringColor);
>>> 340: g.drawRoundRect(5, 3,
On Mon, 16 Aug 2021 18:49:31 GMT, Sergey Bylokhov wrote:
> Don't you need to restore the properties of Graphics2D?
I might as well.
-
PR: https://git.openjdk.java.net/jdk/pull/5082
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing border on the focused component anyways.
Alexander Zuev has
On Fri, 13 Aug 2021 19:17:13 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the
On Mon, 16 Aug 2021 02:15:55 GMT, Sergey Bylokhov wrote:
> Can you please create of blend of two images, one for common focused
> button(with border) and another one w/o. Just to check that the border is
> drawn in the similar location and using similar "shape".
Here is the overlap of two
On Fri, 13 Aug 2021 19:17:13 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the
On Thu, 12 Aug 2021 18:51:10 GMT, Sergey Bylokhov wrote:
> Probably solution should be somewhere similar to this one
That works for icons but for text it would create a terrible mess, text with
glow effect will be unreadable. I made code that draws the focus ring instead
without drawing the
On Fri, 13 Aug 2021 12:15:38 GMT, Prasanta Sadhukhan
wrote:
> UIManager.getColor(). should suffice
Fixed.
> But I am not sure with this hardcoded values..Can't we leverage viewRect or
> textRect to get the required coordinates?
viewRect is set to be exactly (0, 0, b.width, b.height). Insets
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing border on the focused component anyways.
Alexander Zuev has
On Fri, 13 Aug 2021 06:18:49 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing border on the focused component anyways.
Alexander Zuev has
On Thu, 12 Aug 2021 18:17:47 GMT, Sergey Bylokhov wrote:
> There are two choices: draw this rectangle ourselves or request this feature
> from the JRS.
There i pushed the code that only draws the focus ring without the rest of the
border.
-
PR:
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing border on the focused component anyways.
Alexander Zuev has
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote:
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote:
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote:
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing
On Thu, 12 Aug 2021 02:15:06 GMT, Sergey Bylokhov wrote:
> Painting the border while the user tries to disable the border via
> setBorderPainted(false) does not look like a correct solution. The user might
> be drawn something there already. I remember we discussed a similar a11y bug
>
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote:
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing
On Wed, 11 Aug 2021 15:16:22 GMT, Prasanta Sadhukhan
wrote:
> Does having 0,0 not create a problem in multiscreen environment?
These coordinates are relative within the Graphics clip of the button so no,
that does not cause any issue. Plus, if it would then button painting would be
broken
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote:
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing
Initial implementation and a test case.
-
Commit messages:
- Test fixes
- 8269951: [macos] Focus not painted in JButton when setBorderPainted(false)
is invoked
Changes: https://git.openjdk.java.net/jdk/pull/5082/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5082=00
29 matches
Mail list logo
