Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v2]

2021-01-06 Thread Alexey Ivanov
On Wed, 6 Jan 2021 08:24:04 GMT, K Suman Rajkumaar wrote: >> test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 68: >> >>> 66: >>> 67: if (!latch.await(5, TimeUnit.MINUTES)) { >>> 68: frame.dispose(); >> >> The `dispose()` method should be called on EDT. > > If I

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v2]

2021-01-06 Thread K Suman Rajkumaar
On Tue, 5 Jan 2021 08:25:00 GMT, Alexey Ivanov wrote: >> K Suman Rajkumaar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update bug8031573.java >> >> Corrected the jtreg tag from @run main bug8031573 to @run main/manual >>

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v2]

2021-01-05 Thread Alexey Ivanov
On Mon, 4 Jan 2021 09:15:14 GMT, K Suman Rajkumaar wrote: >> Hi All, Could you please review this fix for JDK16? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. >> >> Fix: Rewritten the above applet based test to a regular

Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v2]

2021-01-04 Thread K Suman Rajkumaar
> Hi All, Could you please review this fix for JDK16? > > Problem Description: The test > open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. > > Fix: Rewritten the above applet based test to a regular java test. > > Best Regards, > K Suman Rajkumaar K Suman Rajkumaar