Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi Avik, Changes looks good to me. Regards, Manajit > On 20-Apr-2016, at 11:37 am, Avik Niyogi wrote: > > Hi All, > I have added some comments and made some minor tweaks as per the inputs > received. > Please review my code changes as available at this link below: >

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi All, I have added some comments and made some minor tweaks as per the inputs received. Please review my code changes as available at this link below: http://cr.openjdk.java.net/~aniyogi/8152492/webrev.02/ With Regards, Avik Niyogi >

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

On 19.04.16 11:46, Avik Niyogi wrote: Hi All, Please review my code changes with inputs received: Can you please add some description of your changes, it seems you removed all code which was added by you previously. http://cr.openjdk.java.net/~aniyogi/8152492/webrev.01/ With Regards, Avik

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi Sergey, I have tried all these Input sources: I am unable to reproduce the test failure as mentioned by you with these inputs. Please provide some screenshots and/or details of the procedure used for this test failure. Thank you in advance. With Regards, Avik Niyogi > On 08-Apr-2016, at

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi, Avik. It seems there is one more bug in this "if". Change the input source to "Hindi Dev.."/"Russian.." then this test fails anyway(it will produce the double action). Moreover if I change the source input to Hindi Transliteration, the test sometimes crashed. Please double check. On