Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Sergey Bylokhov
I just double checked that if I compiles the subclass when the parent class has not this method, then recompiles a new parent, the correct method in subclass still called, so it seems fine. Probably there are some other cases, which will be checked during ccc review. Could it break a binary

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Scherbatiy
On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that if I compiles the subclass when the parent class has not this method, then recompiles a new parent, the correct method in subclass still called, so it seems fine. Probably there are some other cases, which will be checked

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Sergey Bylokhov
On 21.08.15 14:20, Alexander Scherbatiy wrote: On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that if I compiles the subclass when the parent class has not this method, then recompiles a new parent, the correct method in subclass still called, so it seems fine. Probably

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 08/21/2015 02:41 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 8/21/2015 2:37 PM, Sergey Bylokhov wrote: On 21.08.15 14:20, Alexander Scherbatiy wrote: On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/21/2015 2:37 PM, Sergey Bylokhov wrote: On 21.08.15 14:20, Alexander Scherbatiy wrote: On 8/21/2015 1:49 PM, Sergey Bylokhov wrote: I just double checked that if I compiles the subclass when the parent class has not this method, then

Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Sergey Bylokhov
Hello. Please review a small fix for jdk9. Long long time ago the next request was filed for jdk 1.4.0: Today, there is no way for a program to access the UI of a JComponent. Adding a getUI method would provide that capability and be consistent with the fact that, for example, the JComponent's

Re: Swing Dev [9] Review Request: 4339584 Adding a getUI public method to JComponent

2015-08-21 Thread Alexander Scherbatiy
On 8/21/2015 1:04 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk9. Long long time ago the next request was filed for jdk 1.4.0: Today, there is no way for a program to access the UI of a JComponent. Adding a getUI method would provide that capability and be consistent