Re: Swing Dev AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-12 Thread Jim Graham
On 12/11/13 2:40 AM, Anton V. Tarasov wrote: On 10.12.2013 23:57, Anthony Petrov wrote: I think that the image shouldn't be aware of any scale. The scale field put into the BufferedImage class means that an image instance should (or shouldn't) be treated as a HiDPI image by the

Re: Swing Dev AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-12 Thread Anton V. Tarasov
[cc'ing to j2d] On 11.12.2013 23:14, Anthony Petrov wrote: Hi Anton, On 12/11/2013 02:40 PM, Anton V. Tarasov wrote: 2. I'm not sure if adding the scale field to the BI is a good idea. I think that the image shouldn't be aware of any scale. After all, it's just an image, a bitmap. It has its

Re: Swing Dev AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-11 Thread Anton V. Tarasov
Hi Anthony, On 10.12.2013 23:57, Anthony Petrov wrote: Hi Anton, I'm not an expert in HiDPI rendering, so I'll defer to Jim and Sergey to comment on the core changes. I still have a few comments regarding the fix: 1. src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java 265

Re: Swing Dev AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-11 Thread Anthony Petrov
Hi Anton, On 12/11/2013 02:40 PM, Anton V. Tarasov wrote: 2. I'm not sure if adding the scale field to the BI is a good idea. I think that the image shouldn't be aware of any scale. After all, it's just an image, a bitmap. It has its real dimensions corresponding to the actual size of the image

Re: Swing Dev AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-10 Thread Anthony Petrov
Hi Anton, I'm not an expert in HiDPI rendering, so I'll defer to Jim and Sergey to comment on the core changes. I still have a few comments regarding the fix: 1. src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java 265 contentView.initialize(peer, null); Are you sure calling