Hi Pavel
On 04/03/2012 07:45 PM, Pavel Porvatov wrote:
Hi Jonathan,
I have several comments:
1. containerParent instanceof JComboBox && containerParent != null
it is not necessary to check "containerParent != null" here
Yes, the null checking is not necessary here.
2.
-if (!int
Hi Pavel,
Here's the update patch,
http://cr.openjdk.java.net/~luchsh/7154030_4/
My comments are inlined.
On 03/27/2012 11:58 PM, Pavel Porvatov wrote:
Hi Jonathan,
Hello Pavel,
Here's the updated patch and automatic test for bug 7154030, could
you please take another look?
http://cr.openj
Hi, Pavel,
the fix looks fine, except code formatting: some of the added/changed
lines are too long, which makes the code less readable.
Thanks,
Artem
On 4/5/2012 7:59 PM, Pavel Porvatov wrote:
Hi,
This is a review request for CR 7146146
Bug description: http://bugs.sun.com/bugdatabase/vi