Re: [8] Review request for 7173873 JFrame.setDefaultCloseOperation(EXIT_ON_CLOSE) will never lead to SE if EXIT_ON_CLOSE is already set

Hi Alexander, The fix looks good. Thanks, SAM On 08.02.2013 19:44, Alexander Scherbatiy wrote: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7173873 webrev: http://cr.openjdk.java.net/~alexsch/7173873/webrev.00 The fix checks the EXIT_ON_CLOSE operation by system security manager e

Re: [8] Review request for 4199622 RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation

Hello, please review a little face-lifting and refactoring: http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.08/ These little changes in BasicComboBoxUI.java are to make code more readable. Regards, - Vlad On 1/16/2013 04:58 PM, Vladislav Karnaukhov wrote: Hello, could you please review

Re: Swing and imageio-related types that are candidates to be FunctionalInterfaces in JDK 8

Lambda is a new feature in Open JDK 8. Could you give some explanation about Lambda and FunctionalInterface annotation usage in AWT/Swing? Here are some statements that can be correct or not (I am not an expert in JDK lambda): 1. It is good practice to use Lambda for the AWT/Swing l

[8] Request for approval for CR 7161759 - TEST_BUG: java/awt/Frame/WindowDragTest/WindowDragTest.java fails to compile, should be modified

Hello, Please review a fix for the issue: 7161759 - TEST_BUG: java/awt/Frame/WindowDragTest/WindowDragTest.java fails to compile, should be modified The webrev is http://cr.openjdk.java.net/~kshefov/7161759/webrev.00/ Thanks, Konstantin

[8] Request for approval for CR 7105119 - [TEST_BUG] [macosx] In test UIDefaults.toString() mast be called with the invokeLater()

Hello, Please review a fix for the issue: 7105119 - [TEST_BUG] [macosx] In test UIDefaults.toString() mast be called with the invokeLater() The webrev is http://cr.openjdk.java.net/~kshefov/7105119/webrev.00/ Thanks, Konstantin

Re: Swing and imageio-related types that are candidates to be FunctionalInterfaces in JDK 8

Lambda is a new feature in Open JDK 8. Could you give some explanation about Lambda and FunctionalInterface annotation usage in AWT/Swing? Here are some statements that can be correct or not (I am not an expert in JDK lambda): 1. It is good practice to use Lambda for the AWT/Swing list

Re: Swing and imageio-related types that are candidates to be FunctionalInterfaces in JDK 8

There is no automagic use of parallelism as part of either the Lambda language features or new libraries. All parallelism is explicit (though unobtrusive). So I think this comment optimizes down to "" :) On 2/11/2013 5:21 PM, Phil Race wrote: Joe, Note that Swing is a single threaded API. Y

Re: Swing and imageio-related types that are candidates to be FunctionalInterfaces in JDK 8

Hi, Joe. Probably the question is not related but why this annotation is named as @FunctionalInterface? Why it wasn't named as @Functional? Or in the future we could get something like @FunctionalClass? @Override isn't @OverrideMethod. 06.02.2013 2:41, Joe Darcy wrote: Hello, As part of Pro

Re: Swing and imageio-related types that are candidates to be FunctionalInterfaces in JDK 8

Probably the question is not related but why this annotation is named as @FunctionalInterface? Why it wasn't named as @Functional? Or in the future we could get something like @FunctionalClass? Because this annotation goes into java.lang and the probability of collision with an existing type na

[8] Request for review: 7184945 [macosx] NPE in AquaComboBoxUI since jdk7u6b17, jdk8b47

Hello, Please review the fix for jdk 8. Fix will be pushed to jdk 7 as well. arrowButton should be checked for null before usage + small cleanup. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7184945 Webrev can be found at: http://cr.openjdk.java.net/~serb/7184945/webrev.00 -- Best re