[8] Review request for 8025070: [javadoc] fix some javadoc errors in javax/swing/

2013-09-26 Thread taras ledkov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8025249 webrev corresponding: http://cr.openjdk.java.net/~alexsch/taras-ledkov/8025249/webrev.00/ The patch contains only simple markup fixes; no changes/fixes in documentation text; the specif

Re: [8] Review request for 8025070: [javadoc] fix some javadoc errors in javax/swing/

2013-09-26 Thread Yuri Nesterenko
OK with me. Build with this fix seems ok in respect to doclint for these files. -yan On 09/26/2013 12:36 PM, taras ledkov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8025249 webrev corresponding: http://cr.openjdk.java.net/~alex

Re: [8] Review request for CR 8012468: [TEST_BUG] javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java doesn't release mouse button

2013-09-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/24/2013 7:09 PM, vera akulova wrote: Hello, Please review a fix for the issue: JDK-8012468 : [TEST_BUG] javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java doesn't release mou

Re: [8] Review request for CR 8012466: [TEST_BUG] javax/swing/JInternalFrame/Test6505027.java doesn't release mouse button

2013-09-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/24/2013 7:06 PM, vera akulova wrote: Hello, Please review a fix for the issue: JDK-8012466 : [TEST_BUG] javax/swing/JInternalFrame/Test6505027.java doesn't release mouse button The

Re: [8] Review request for CR 8004294: [TEST_BUG] javax/swing/JSpinner/4973721/bug4973721.java failed on win2003

2013-09-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/24/2013 7:03 PM, vera akulova wrote: Hello, Please review a fix for the issue: JDK-8004294 : [TEST_BUG] javax/swing/JSpinner/4973721/bug4973721.java failed on win2003 The webrev is htt

Re: [8] Review request for 8025070: [javadoc] fix some javadoc errors in javax/swing/

2013-09-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/26/2013 12:36 PM, taras ledkov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8025249 webrev corresponding: http://cr.openjdk.java.net/~alexsch/taras-ledkov/8025249/webrev.00

Re: [8] Review request for 8025070: [javadoc] fix some javadoc errors in javax/swing/

2013-09-26 Thread Alexander Scherbatiy
The title mentions the issue 8025070 but the webrev contains the fix for the issue 8025249. Could you resend the request with the right bugid. Thanks, Alexandr. On 9/26/2013 12:36 PM, taras ledkov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjd

Re: [8] Review request for CR 7133532: [macosx] closed/javax/swing/JScrollBar/bug4202954/bug4202954.java fails on MacOS

2013-09-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/25/2013 3:50 PM, vera akulova wrote: Hi Alexandr, Thank for your answer. Indeed this test can be automated, please review a new fix version: http://cr.openjdk.java.net/~kshefov/7133532/webrev.01/

[8] Review request for 8025249: [javadoc] fix some javadoc errors in javax/swing/

2013-09-26 Thread taras ledkov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8025249 webrev corresponding: http://cr.openjdk.java.net/~alexsch/taras-ledkov/8025249/webrev.00/ The patch contains only simple markup fixes; no changes/fixes in documentation text; the speci

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

2013-09-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/26/2013 2:27 AM, mikhail cherkasov wrote: a new webrev: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.01/ no changes, I've turned off laptop before the webrev upload was c

Re: [8] Review request for 8025249: [javadoc] fix some javadoc errors in javax/swing/

2013-09-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/26/2013 5:50 PM, taras ledkov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8025249 webrev corresponding: http://cr.openjdk.java.net/~alexsch/taras-ledkov/8025249/webrev.00