Re: [9] RFR 8039750: KSS: Replace MetalLazyValue with lambda

2014-04-10 Thread Alexander Scherbatiy
On 4/9/2014 7:40 PM, sergey malenkov wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~malenkov/8039750.9.0/ http://bugs.openjdk.java.net/browse/JDK-8039750 The MetalLazyValue is removed, all usages replaced with the LazyValue lambdas. The TableLazyValue is r

Re: [9] RFR 8039750: KSS: Replace MetalLazyValue with lambda

2014-04-10 Thread sergey malenkov
Hello, Could you please review the second version of the fix: http://cr.openjdk.java.net/~malenkov/8039750.9.1/ Small type in the JTable class was fixed. Tests were added. Thanks, SAM On 09.04.2014 19:40, sergey malenkov wrote: Hello, Could you please review the following fix: http://cr.openj

Re: [9] RFR 8039750: KSS: Replace MetalLazyValue with lambda

2014-04-10 Thread Alexander Scherbatiy
The fix looks good. Thanks, Alexandr. On 4/10/2014 5:19 PM, sergey malenkov wrote: Hello, Could you please review the second version of the fix: http://cr.openjdk.java.net/~malenkov/8039750.9.1/ Small type in the JTable class was fixed. Tests were added. Thanks, SAM On 09.04.2014 19:4

Re: [9] Review request for 8036983 - JAB:Multiselection Ctrl+CursorUp/Down and ActivateDescenderPropertyChanged event

2014-04-10 Thread Vivi An
Updated webrev: http://cr.openjdk.java.net/~dmarkov/8036983/jdk9/webrev.01/ Comments as below Thanks Vivi On 4/9/2014 8:08 AM, Alexander Scherbatiy wrote: On 4/8/2014 9:19 PM, Vivi An wrote: Hello, Could you please review the fix for JDK 9? This bug is JAB related. ActivateDescenderPro

Re: [9] Review request for 8036983 - JAB:Multiselection Ctrl+CursorUp/Down and ActivateDescenderPropertyChanged event

2014-04-10 Thread Petr Pchelko
Hello, Vivi. >> Is it possible to write a test (manual or automated) for the fix? > Two test files (One for JTree, one for JTable) attached to the bug for manual > test, comments added in each file about the how to do the test. Is is possible to make an automatic test? You could show the JTree

Re: [9] RFR 8039750: KSS: Replace MetalLazyValue with lambda

2014-04-10 Thread Sergey Bylokhov
Hi, Sergey. The fix looks good, but can you reformat the changes in JTable before the push, it seems that this file use 80-line alignment. On 10.04.2014 17:19, sergey malenkov wrote: Hello, Could you please review the second version of the fix: http://cr.openjdk.java.net/~malenkov/8039750.9.1

Re: [9] Review request for 8036983 - JAB:Multiselection Ctrl+CursorUp/Down and ActivateDescenderPropertyChanged event

2014-04-10 Thread Vivi An
Thanks Petr Please see comments inline. Plus, one more question, does new package private function requires CCC approval? ~ Vivi On 4/10/2014 7:25 AM, Petr Pchelko wrote: Hello, Vivi. Is it possible to write a test (manual or automated) for the fix? Two test files (One for JTree, one for