Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

On 5/22/2014 9:59 PM, Pete Brunet wrote: I'd like one more reviewer of this fix. Also I removed the @Deprecated and will deal with this in a following JBS issue. http://cr.openjdk.java.net/~ptbrunet/JDK-8009883/webrev.04/ The fix looks good for me. Thanks, Alexandr. Pete On 5/21/1

Re: [9] Review Request: 8043610 Sorting columns in JFileChooser fails with AppContext NPE

The fix looks good to me. -- best regards, Anthony On 5/22/2014 5:43 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8043610 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8043610/webrev/ The problem is tha

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

Thanks Alexandr. So far Alexandr is the only reviewer of this. I'd like one more. Thanks, Pete On 5/23/14 5:34 AM, Alexander Scherbatiy wrote: > On 5/22/2014 9:59 PM, Pete Brunet wrote: >> I'd like one more reviewer of this fix. >> >> Also I removed the @Deprecated and will deal with this in a

Re: [9] Review Request: 8043610 Sorting columns in JFileChooser fails with AppContext NPE

The fix looks good for me. Thanks, Alexandr. On 5/22/2014 5:43 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8043610 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8043610/webrev/ The problem is th

Re: [9] Review Request: 8031485 [macosx] Combo box consuming escape key events

Hi, Petr. The fix looks good. On 5/14/14 6:13 PM, Petr Pchelko wrote: Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8031485 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8031485/webrev.00/ We should not consume the ESC if the popup is not

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

Hello, Peter. Looks good to me too. With best regards. Petr. On May 23, 2014, at 7:14 PM, Pete Brunet wrote: > Thanks Alexandr. > > So far Alexandr is the only reviewer of this. I'd like one more. > > Thanks, Pete > > On 5/23/14 5:34 AM, Alexander Scherbatiy wrote: >> On 5/22/2014 9:59 PM,

[9] RFR 8019180: Use JComboBox as it's own ActionListener leads to unexpected behaviour

Hello, Could you please review the following fix: http://cr.openjdk.java.net/~malenkov/8019180.9.0/ http://bugs.openjdk.java.net/browse/JDK-8019180 Thanks, SAM

Re: [9] RFR 8019180: Use JComboBox as it's own ActionListener leads to unexpected behaviour

Hi, Sergey. The fix looks good. On 5/23/14 8:24 PM, sergey malenkov wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~malenkov/8019180.9.0/ http://bugs.openjdk.java.net/browse/JDK-8019180 Thanks, SAM -- Best regards, Sergey.