Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2015-12-21 Thread Avik Niyogi
Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8015748 Webrev: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.00/ Issue: The manual

Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

2015-12-21 Thread Rajeev Chamyal
Fix looks good to me. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 21 December 2015 09:47 To: Sergey Bylokhov Cc: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

2015-12-21 Thread Rajeev Chamyal
Hello Sergey, Yes, similar issue is there with maximize as well. I will raise a separate bug for it. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 19 December 2015 03:51 To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@openjdk.java.net

Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2015-12-21 Thread Rajeev Chamyal
Hello Alexandr, I have updated the fix. Please review it. http://cr.openjdk.java.net/~rchamyal/8075084/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: 10 December 2015 16:59 To: Rajeev Chamyal Cc: Sergey Bylokhov; Prasanta Sadhukhan;

Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

2015-12-21 Thread Avik Niyogi
Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8016665 Webrev: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/ Issue: The manual

Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2015-12-21 Thread Rajeev Chamyal
Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev: http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for

Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2015-12-21 Thread Alexander Scherbatiy
On 21/12/15 12:21, Rajeev Chamyal wrote: Hello Alexandr, I have updated the fix. Please review it. http://cr.openjdk.java.net/~rchamyal/8075084/webrev.01/ When a modal dialog is shown does it block all windows or is it possible that a modal dialog blocks some windows and does not block