Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2016-01-11 Thread Rajeev Chamyal
Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January 2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for J

Re: Review request for JDK-8145060 Minimizing a JInternal frame not shifting focus to frame below it

2016-01-11 Thread Rajeev Chamyal
Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 30 December 2015 13:33 To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@openjd

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-11 Thread Semyon Sadetsky
Hi Avik, Shouldn't the graphics transformation be restored before the paintString() call? It seems to me that left/right insets need to be swapped for right-to-left painting with mirroring graphics transformation. --Semyon On 1/5/2016 1:22 PM, Avik Niyogi wrote: Hi All, Please find webrev

Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

2016-01-11 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 30/12/15 11:26, Rajeev Chamyal wrote: Hello All, I need one more review for this webrev. http://cr.openjdk.java.net/~rchamyal/4769772/webrev.03/ Regards, Rajeev Chamyal -Original Message- From: Alexey Ivanov Sent: 28 December 2015 19:1

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

2016-01-11 Thread Alexander Scherbatiy
Is it possible to make an automated test which compare colors from the 5/6 part of the progress bar when its value is set to 0 and 30? If these colors are the same it means that the progress has been painted on the left side instead of right. Thanks, Alexandr. On 04/01/16 12:52, Avik Niyogi

RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-11 Thread Pete Brunet
Please review this patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.00/ The issue being resolved is that the JTabbedPane code can't solely rely on tabComponent when fetching the index in the parent component. tabComponent is optionally used and its presence indicates that the assoc

Review request for JDK-8146276 : Right aligned ToolBar component does not appear

2016-01-11 Thread Rajeev Chamyal
Hello All, Please review the following fix for Jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-8146276 Webrev: http://cr.openjdk.java.net/~rchamyal/8146276/webrev.00/ Issue : Right aligned ToolBar component does not appear Cause: While calculating the minimum layout size for the components