Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

Hi Sergey, I confirm that it is built. I built it locally on Linux and Solaris. --Semyon On 3/9/2016 1:00 PM, Sergey Bylokhov wrote: Hi, Semyon. A few initial questions. Please confirm that the changes were build successfully on all platforms via jprt. I assume that jck passed after the

Re: Review Request: JDK-7012008 JDesktopPane - Wrong background color with Win7+WindowsLnf

Looks good. --Semyon On 3/10/2016 9:45 AM, Prem Balakrishnan wrote: Hi Semyon and Alexey, Thankyou for the Review. I have updated the test as per review comments. http://cr.openjdk.java.net/~arapte/prem/7012008/webrev.01/

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

Hello Sergey, I have updated the test as per review comments. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.02/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 09 March 2016 18:57 To: Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: Review request

Re: Review Request: JDK-7012008 JDesktopPane - Wrong background color with Win7+WindowsLnf

Hi Semyon and Alexey, Thankyou for the Review. I have updated the test as per review comments. http://cr.openjdk.java.net/~arapte/prem/7012008/webrev.01/ Regards, Prem From: Alexey Ivanov Sent: Wednesday, March 09, 2016 3:58 PM To: Prem Balakrishnan; Rajeev Chamyal; Sergey

[9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8151303 webrev: http://cr.openjdk.java.net/~alexsch/8151303/webrev.00 The AquaUtils does not take into account MultiResolutionImage for selected/disabled/lightened images generation. The fix also leaves the

Re: [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

Hello Sergey, I have run JCK tests for HTMLWriter and AbstractWriter with this fix and all passed. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 09 March 2016 15:54 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Review

Re: [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

Probably we should enhance ImageProducer/Tk.createImage/ImageFilter to support this functionality? It seems that the number of usage of this check "image instanceof MultiResolutionImage" will grow over time. I think that at least our own API should support MultiResolutionImage w/o such checks,

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

Hi, Rajeev. The fix looks fine, but the test should be updated. JFrame is created on non-EDT thread. It is unclear what l we should test(some specific,all,default?). This also can be simplified: 70 if (testFailed) { 71 dispose(); 72 throw new

Re: [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

Hi, Rajeev. Please confirm that there are no new issues in the jck after this fix. On 09.03.16 12:18, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-8150225 Webrev:

Re: Review Request: JDK-7012008 JDesktopPane - Wrong background color with Win7+WindowsLnf

Hi Prem, The fix itself looks good. Yet I have some questions to the test. Could you please place the comment with @test tag and other before the class declaration rather than before imports? Could you place asterisk in front of each line in this comment block? It will look consistent with

Re: Review Request: JDK-7012008 JDesktopPane - Wrong background color with Win7+WindowsLnf

Hi Prem, The fix looks good. One remark to the test: it should not fail on platforms other than Windows but just skip testing and pass. --Semyon On 3/9/2016 9:59 AM, Prem Balakrishnan wrote: Hi*,* Please review fix for JDK9, *Bug:*https://bugs.openjdk.java.net/browse/JDK-7012008**

[9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

Hello All, Please review the following fix for Jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-8150225 Webrev: http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/ http://cr.openjdk.java.net/~rchamyal/8146276/webrev.00/ Issue : JCK conformance test failed due to fix for bug