Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

It is not usually a good idea to have a duplicated code which should be updated every time in several places. Is it possible to move the methods used both in AquaTruncatingTabbedPaneLayout and AquaTruncatingTabbedScrollPaneLayout to TabbedPaneLayout with different names and then reused?

Re: [9] Review request for 8152159 LabelUI is not updated for TitledBorder

On 18/03/16 19:40, Semyon Sadetsky wrote: Hi Alexander, Maybe it would be more optimal to update UI in a property change listener added to the UIManager? public void propertyChange(PropertyChangeEvent e) { if ("lookAndFeel" == e.getPropertyName()) { label.updateUI();

Re: RfR, JDK-8145228 , Java Access Bridge, getAccessibleStatesStringFromContext doesn't wrap the call to getAccessibleRole

+1. -phil. On 02/29/2016 12:35 PM, Pete Brunet wrote: Please review this change which runs code on the EDT like it should have. http://cr.openjdk.java.net/~ptbrunet/JDK-8145228/webrev.00/

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

Hi Phil, Thank for review. You will find my reply below in the text. The updated webrev is http://cr.openjdk.java.net/~ssadetsky/8145547/webrev.01/ It also contains: - new properties jdk.gtk.version and jdk.gtk.verbose - appearance tuning for Ubuntu 15 (GTK 3.14). It may require more but we c

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi Sergey, https://bugs.openjdk.java.net/browse/JDK-8151282 is open and in progress. With Regards, Avik Niyogi > On 19-Mar-2016, at 4:52 pm, Sergey Bylokhov > wrote: > > I guess you need a separate CR for this, because JDK-8015748 was closed

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, I agree with what you said regarding the look and feel looking different. But this bug arrises due to setting of TabbedPaneScrollLayout only. If Scroll Layout is not meant for Aqua look and feel should not the setting of this parameter instead throw a helpful error saying this para

CFV: New Swing Group Member: Semyon Sadetsky

I hereby nominate Semyon Sadetsky (OpenJDK user name: ssadetsky) to Membership in the Swing Group. Semyon is active member of Swing group and contributed a lot of fixes which include Swing TimerQueue race condition improvement, UndoManager deadlock resolving, proposing and implementation a p

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi Sergey, This bug fix has been committed and resolved. Does not require a review. With Regards, Avik Niyogi > On 21-Mar-2016, at 10:42 am, Avik Niyogi wrote: > > Hi Sergey, > https://bugs.openjdk.java.net/browse/JDK-8151282 > is open and in p

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi Sergey, Please review the following code change. With Regards, Avik Niyogi > On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy > wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 14/03/16 16:25, Avik Niyogi wrote: >> Hi All, >> Please review code changes made as per inputs

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Sergey, Please review the following code changes. With Regards, Avik Niyogi > On 17-Mar-2016, at 7:03 pm, Alexander Scherbatiy > wrote: > > > The fix looks good to me. > > Just a small note: it is better to remove comment "527 //" since it > does not have a description. > > Thank

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Rajeev, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:17 pm, Avik Niyogi wrote: > > Hi Sergey, > > Please review the following code changes. > With Regards, > Avik Niyogi >> On 17-Mar-2016, at 7:03 pm, Alexander Scherbatiy >> mailto:alexandr.sch

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Manajit, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:20 pm, Avik Niyogi wrote: > > Hi Rajeev, > Please review the following code changes. > > With Regards, > Avik Niyogi >> On 21-Mar-2016, at 12:17 pm, Avik Niyogi >