Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-18 Thread Pete Brunet
Anton, If you'd like to check out the changeset I just pushed it. Pete On 7/18/16 3:25 PM, Pete Brunet wrote: > JPRT ran OK. > > On 7/15/16 9:24 AM, Pete Brunet wrote: >> On 7/15/16 8:42 AM, Alexandr Scherbatiy wrote: >>> On 7/15/2016 4:39 AM, Pete Brunet wrote: Hi Alexandr, Thanks very

[9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

2016-07-18 Thread Ajit Ghaisas
Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-7096375 Swing ignores first click after decreasing system's time. Fix : BasicButtonListener keeps track of the last time when a button is pressed. This is used while discarding mouse press events to handle multiClickThreshold.

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-07-18 Thread Phil Race
/** - * Sets the {@code TreeCellRenderer} to {@code tcr}. This invokes - * {@code updateRenderer}. + * Called when the {@code cellRenderer} property is changed in + * the drawn tree component. * - * @param tcr the new value + * @param tcr the new value of the

Re: [9] Review request for 7020860: BasicTreeUI contains getters/setters with unclear spec

2016-07-18 Thread Semyon Sadetsky
On 7/18/2016 7:29 PM, Phil Race wrote: /** - * Sets the {@code TreeCellRenderer} to {@code tcr}. This invokes - * {@code updateRenderer}. + * Called when the {@code cellRenderer} property is changed in + * the drawn tree component. * - * @param tcr the new value +

Re: RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-07-18 Thread Pete Brunet
JPRT ran OK. On 7/15/16 9:24 AM, Pete Brunet wrote: > > On 7/15/16 8:42 AM, Alexandr Scherbatiy wrote: >> On 7/15/2016 4:39 AM, Pete Brunet wrote: >>> Hi Alexandr, Thanks very much for the review. I updated the webrev. >>> See >>> http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.01/ >>

RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

2016-07-18 Thread Pete Brunet
Please review the following: Bug: https://bugs.openjdk.java.net/browse/JDK-8161483 Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.00/ This is a followon to the patch for JDK-8145207 [macosx] JList, VO can't access non-visible list items In order to fixJDK-8145207the

[9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

2016-07-18 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8160087 webrev: http://cr.openjdk.java.net/~ssadetsky/8160087/webrev.00/ A warning is added to avoid issues in user code to throw exceptions which were masked before. See bug descriptions for details. --Semyon

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

2016-07-18 Thread Rajeev Chamyal
Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8158918/webrev.01/ Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 14 July 2016 20:54 To: Rajeev Chamyal; Semyon Sadetsky; swing-dev@openjdk.java.net Subject: Re: Swing Dev>[9] Review