Re: [9] Review request for 8163193 Metal L gradient is lighter on HiDPI display after the fix JDK-8143064

2016-08-30 Thread Sergey Bylokhov
Hi, Alex. Looks fine. - Note that this code uses the logic similar to JViewport: switch (volatileImage.validate(config)) { . } = Also note that another possible solution is to use this pattern in the createImage(): if (config == null) { return new

Re: [9] Review request for 8163193 Metal L gradient is lighter on HiDPI display after the fix JDK-8143064

2016-08-30 Thread Semyon Sadetsky
The fix looks good. --Semyon On 8/30/2016 12:13 PM, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8163193 webrev: http://cr.openjdk.java.net/~alexsch/8163193/webrev.00 This is a regression from the fix JDK-8143064 Icons are

Re: [9] Review request for 8160160: The menu displayed nothing with the option"-server -d64 -Xmixed -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel".

2016-08-30 Thread Sergey Bylokhov
Hi, Semyon. I suggest to double check the HW menu/popups, they should have the correct border, because they should use the top level window, which should contains correct shadow effect. Note that after the fix we should not have two borers in such cases. On 29.08.16 20:11, Alexandr

Re: [9] Review request for 8164032 JViewport backing store image is not scaled on HiDPI display

2016-08-30 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8164032/webrev.04/ The Component.createVolatileImage() is used to create a backing store volatile image. On 8/29/2016 4:18 PM, Sergey Bylokhov wrote: On 19.08.16 10:15, Alexandr Scherbatiy wrote: On 8/18/2016

[9] Review request for 8163193 Metal L gradient is lighter on HiDPI display after the fix JDK-8143064

2016-08-30 Thread Alexandr Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8163193 webrev: http://cr.openjdk.java.net/~alexsch/8163193/webrev.00 This is a regression from the fix JDK-8143064 Icons are not properly rendered with Windows L on HiDPI display. The graphics for

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-08-30 Thread Avik Niyogi
Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/ Thank you in advance. With Regards, Avik Niyogi > On 29-Aug-2016, at 5:55 pm,

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

2016-08-30 Thread Alexandr Scherbatiy
On 8/30/2016 12:17 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. *http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/* I believe the @return tag should