[9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-16 Thread Prasanta Sadhukhan
Hi All, Please review a simple fix for a swing issue where it is seen that a closed test was failing on Nimbus LaF Bug: https://bugs.openjdk.java.net/browse/JDK-7190578 webrev: http://cr.openjdk.java.net/~psadhukhan/7190578/webrev.00/ This is is continuation to the closed review and this just

Re: RFR: 8167182: Exported elements referring to inaccessible types in jdk.accessibility

2016-11-16 Thread Sergey Bylokhov
Looks fine. On 16.11.16 1:33, Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8167182 Webrev: http://cr.openjdk.java.net/~prr/8167182/ There are three fields exposed in the accessibility docs which are of types that are not exported : http://download.java.net/java/jdk9/docs/jre/

Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-16 Thread Sergey Bylokhov
It seems that the test has the main() method and ".html" file is not necessary? On 16.11.16 12:38, Prasanta Sadhukhan wrote: I intended to open this testcase so remove dependancy on Util library. I tested with other LAFs and it passed. -- Best regards, Sergey.

Re: [9] RFR JDK-7190578: Nimbus: css test for 4936917 fails

2016-11-16 Thread Prasanta Sadhukhan
Ok. Removed html file and updated test not to use JApplet. Please find the updated webrev http://cr.openjdk.java.net/~psadhukhan/7190578/webrev.01/ Regards Prasanta On 11/16/2016 7:55 PM, Sergey Bylokhov wrote: It seems that the test has the main() method and ".html" file is not necessary?

Re: [9] Review request for 8169719 WrappedPlainView.modelToView() should return Rectangle2D

2016-11-16 Thread Sergey Bylokhov
Looks fine. On 15.11.16 23:51, Phil Race wrote: +1 -phil On 11/15/2016 12:32 PM, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8169719/webrev.02 - The test is removed. Floating point values mean that the test passes but only integral