Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Avik Niyogi
In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only arrow keys would work within ungrouped radio buttons but not within grouped radio button groups. Also, verified Aqua LAF with native application on MacBook. So to test this focus traversal, it works only in LAF which

[9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

2017-01-11 Thread Prasanta Sadhukhan
Hi All, Please review the name change for this regression test which was causing jtreg to fail as it was not finding the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8172558 Filename was javax/swing/JTable/8133919/DrawGridLInesTest.java [whith capital I] but test has jtreg tag @run

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Alexandr Scherbatiy
On 1/11/2017 2:01 PM, Avik Niyogi wrote: Hi All, I have addressed the inputs received in the following update. Please review the same for JDK 9. http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/ With Regards, Avik Niyogi On

8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Avik Niyogi
Hi All, Kindly review the proposed fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8172509 Webrev: http://cr.openjdk.java.net/~aniyogi/8172509/webrev.00/ Issue: The focus

Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2017-01-11 Thread Avik Niyogi
Hi Alexander, The following is my input for this webrev: In case the LAF is Aqua, the check for combobox alignment is skipped. Instead, if default LAF is Aqua, the LAF should be changed to cross platform LAF to check if it works on other LAF or not. Either run this in a loop with checks for all

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Prasanta Sadhukhan
I guess we need to throw the exception if changing LaF fails instead of silently consuming it!! Regards Prasanta On 1/11/2017 2:16 PM, Avik Niyogi wrote: Hi All, Kindly review the proposed fix for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8172509* * * *Webrev:

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-11 Thread Avik Niyogi
Hi All, I have addressed the inputs received in the following update. Please review the same for JDK 9. http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/ With Regards, Avik Niyogi > On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan >