Re: [10] RFR JDK-8173739: JPopupMenu does not disappear on KeyEvent

2017-07-12 Thread Sergey Bylokhov
I'll take a look tomorrow just to refresh the memory on how this part of code works. - prasanta.sadhuk...@oracle.com wrote: > Any further comments on this? Can it be committed now? > > Regards > Prasanta > On 7/4/2017 12:35 PM, Prasanta Sadhukhan wrote: > > OK. Updated webrev to post

Re: [10] RFR JDK-8173739: JPopupMenu does not disappear on KeyEvent

2017-07-12 Thread Prasanta Sadhukhan
Any further comments on this? Can it be committed now? Regards Prasanta On 7/4/2017 12:35 PM, Prasanta Sadhukhan wrote: OK. Updated webrev to post ungrab from a method when internal frame is deselected. There is no grab event. When popup menu is visible, it grab window in BasicPopupMenuUI

[10] RFR JDK-8184244: UIDefaults.addResourceBundle uses system class loader

2017-07-12 Thread Prasanta Sadhukhan
Hi All, Please review a doc fix to use correct "system" classloader instead of mentioned "application" classloader. Bug: https://bugs.openjdk.java.net/browse/JDK-8184244 webrev: http://cr.openjdk.java.net/~psadhukhan/8184244/webrev.00/ Regards Prasanta

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-12 Thread Prasanta Sadhukhan
On 7/13/2017 6:58 AM, Semyon Sadetsky wrote: On 7/11/2017 10:54 PM, Prasanta Sadhukhan wrote: Thanks Semyon for the pointer. Calling NewGlobalRef makes these fields a global ref which can then be accessed from different thread, as doGetColumnInfo() is called from COM invoker thread and

Re: [10] RFR JDK-8183529: FilleChooser in "Detail view" does not change the Language of the column headings

2017-07-12 Thread Semyon Sadetsky
On 7/11/2017 10:54 PM, Prasanta Sadhukhan wrote: Thanks Semyon for the pointer. Calling NewGlobalRef makes these fields a global ref which can then be accessed from different thread, as doGetColumnInfo() is called from COM invoker thread and initIDs() from main thread. It is unrelated to

Re: [10] RFR JDK-8184244: UIDefaults.addResourceBundle uses system class loader

2017-07-12 Thread Sergey Bylokhov
Looks fine. - prasanta.sadhuk...@oracle.com wrote: > Hi All, > > Please review a doc fix to use correct "system" classloader instead of > > mentioned "application" classloader. > Bug: https://bugs.openjdk.java.net/browse/JDK-8184244 > webrev:

Re: [10] RFR JDK-8184244: UIDefaults.addResourceBundle uses system class loader

2017-07-12 Thread Semyon Sadetsky
+1 It seems java.security.Provider class may have the same issue. 81 * using the {@link ClassLoader#getSystemClassLoader application class loader}. Can you create a bug? --Semyon On 7/12/2017 7:56 AM, Prasanta Sadhukhan wrote: Hi All, Please review a doc fix to use correct "system"