Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8187957
webrev: http://cr.openjdk.java.net/~psadhukhan/8187957/webrev.00/
Please review a fix for an issue where it is seen string with "tab" in
them are not aligned properly.
This is because while calculating tab stop postion, it is calcula
Hi Sergey,
Are the changes fine now?
Thanks,
Krishna
-Original Message-
From: Krishna Addepalli
Sent: Monday, November 6, 2017 9:02 PM
To: Sergey Bylokhov ; swing-dev@openjdk.java.net
Subject: RE: [10][JDK-8178430] JMenu in GridBagLayout flickers when
label text shows "..." and is upd
Hi Sergey,
Could you review this and let me know your feedback?
Thanks,
Krishna
From: Krishna Addepalli
Sent: Friday, October 27, 2017 4:43 PM
To: swing-dev@openjdk.java.net
Subject: [10][JDK-8187936] Automatically selecting a new JTree node in a model
listener can cause unusual behavio
Any update on this Sergey?
-Original Message-
From: Krishna Addepalli
Sent: Thursday, October 26, 2017 2:13 PM
To: swing-dev@openjdk.java.net; Sergey Bylokhov
Subject: RE: [10][JDK-8075084] JOptionPane.showMessageDialog causes
JScrollBar to move
Hi Sergey,
I have recreated the webrev
Hi Prasanta,
It seems to me that the result of the sentence should be truncated to
int, not its members.
The test can be automated.
--Semyon
On 11/08/2017 03:25 AM, Prasanta Sadhukhan wrote:
Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8187957
webrev: http://cr.openjdk.java.net/~p
The documentation for PropertyChangeEvent and PropertyChangeListener is not
completely clear on this point, but I think the intent is that the listener
will be called *after* the new property value has been installed in the object,
which is not the case in your code.
Alan
> On Nov 7, 2017,
This fix was already published on Swing alias:
http://mail.openjdk.java.net/pipermail/swing-dev/2016-October/006808.html
Please continue your discussions in the original thread.
--Semyon
On 11/08/2017 06:51 AM, Krishna Addepalli wrote:
Any update on this Sergey?
-Original Message-
F
Hi, Prasanta.
Is it possible that dropping the float part of "tabSize" and "x" will
cause Off-by-one error? For example:
float tabSize=3.99f;
float x=21.9f;
int tabBase=0;
649 int ntabs = ((int) x - tabBase) / (int)tabSize;
650 return tabBase + ((ntabs + 1) * tabSiz
Hi Sergey,
It also may be written as
int ntabs = (int)((x - tabBase) / tabSize);
return tabBase + (ntabs + 1) * tabSize
See my previous comment.
--Semyon
On 11/08/2017 10:24 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
Is it possible that dropping the float part of "tabSize" and "x" w
On 08/11/2017 10:39, Semyon Sadetsky wrote:
It also may be written as
int ntabs = (int)((x - tabBase) / tabSize);
return tabBase + (ntabs + 1) * tabSize
Yes "(int)+1" is also can be used for positive values, but the "ceil()"
is better since this purpose of this method, and in gene
On 11/08/2017 11:28 AM, Sergey Bylokhov wrote:
On 08/11/2017 10:39, Semyon Sadetsky wrote:
It also may be written as
int ntabs = (int)((x - tabBase) / tabSize);
return tabBase + (ntabs + 1) * tabSize
Yes "(int)+1" is also can be used for positive values, but the
"ceil()" is bett
On 08/11/2017 11:38, Semyon Sadetsky wrote:
Yes "(int)+1" is also can be used for positive values, but the
"ceil()" is better since this purpose of this method, and in general
it works for negative values as well.
There may not be negative values here, so Math.ceil() is redundant.
I do not se
On 11/8/17 12:24 PM, Sergey Bylokhov wrote:
On 08/11/2017 11:38, Semyon Sadetsky wrote:
Yes "(int)+1" is also can be used for positive values, but the
"ceil()" is better since this purpose of this method, and in general
it works for negative values as well.
There may not be negative values he
Hi Sergey,
Please find updated webrev which changes "graphicsConfig" notification
to "graphicsConfiguration". Added auto test for this property and also
fire the notification after the change.
http://cr.openjdk.java.net/~psadhukhan/8178025/webrev.07/
Regards
Prasanta
On 11/8/2017 11:11 AM, Pr
14 matches
Mail list logo
