+1
--Semyon
On 11/23/2017 11:54 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8043334
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8043334/webrev.00
The small typo was fixed.
Hi, Prasanta.
A few notes about the fix:
- Can we get an NPE in adjustScrollPositionIfNecessary at
2391 list.scrollRectToVisible(cellBounds); Not sure that
scrollRectToVisible is ready for null.
- I think the assignment below can be simplified
cellBounds = startRect != null ? sta
Hello.
Please review the fix for jdk10. This is the second attempt to move
windows L&F from non-windows platforms. The first attempt JDK-6461834[1]
was reverted because of JDK-8184813[2].
The root cause of those issue was fixed in JDK-8075255[3], and now we
can move it again.
Bug: https://bug
Hi Sergey,
On 11/28/2017 3:33 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
A few notes about the fix:
- Can we get an NPE in adjustScrollPositionIfNecessary at
2391 list.scrollRectToVisible(cellBounds); Not sure that
scrollRectToVisible is ready for null.
cellBounds is not null for this c
On 27/11/2017 22:40, Prasanta Sadhukhan wrote:
On 11/28/2017 3:33 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
A few notes about the fix:
- Can we get an NPE in adjustScrollPositionIfNecessary at
2391 list.scrollRectToVisible(cellBounds); Not sure that
scrollRectToVisible is ready for null.
Ok. I have added the check for scrollRectToVisible() too.
http://cr.openjdk.java.net/~psadhukhan/8191639/webrev.02/
Regards
Prasanta
On 11/28/2017 1:01 PM, Sergey Bylokhov wrote:
On 27/11/2017 22:40, Prasanta Sadhukhan wrote:
On 11/28/2017 3:33 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
A few n
